From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9FE18C43381 for ; Thu, 28 Feb 2019 17:03:52 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 6A966218CD for ; Thu, 28 Feb 2019 17:03:52 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="TfkRqlf5" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732446AbfB1RDv (ORCPT ); Thu, 28 Feb 2019 12:03:51 -0500 Received: from mail-pg1-f195.google.com ([209.85.215.195]:44298 "EHLO mail-pg1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1732229AbfB1RDu (ORCPT ); Thu, 28 Feb 2019 12:03:50 -0500 Received: by mail-pg1-f195.google.com with SMTP id j3so9983365pgm.11 for ; Thu, 28 Feb 2019 09:03:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=1gDhIJlwlhkyRzPv4MupxFCDYU16PjpO2Ctgq48qJWo=; b=TfkRqlf5Qhnvkob3suaAmOpcyP1SFKldnMlZG0M8MA2tN4yMrZQA9/dlG+Md05Ocnu VtpxuFdimOljGSdfzConz6Z+MRcn3WreRaCCFkQD4lRha3t4lqaglAhchHQOnIfcqhS7 SJi0udgu0Z8opxD/mXpICbSyN5tfP468QMd/msQ+i3cKX35S5OSssXjB2MMi5GBKaNww M5BHr22MVgDl0itOaO7wfbbktzzMv5UzNyutHeHo2R/Sir3rSn8O0iWM0ADeEVPikhwn kGq9+Pjl6qWnoSEUXFlQocpz6n2Ve/nFaZobmCzrbpl12YGaHEoPB62u7AQQhW3O8S64 FbIg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=1gDhIJlwlhkyRzPv4MupxFCDYU16PjpO2Ctgq48qJWo=; b=IsDG/eWtGMuL6fQEoaWxvWgStt4pQXQio9N93ipXyKX34NYAWdMw7ydoUB4nBP8+eq F4jBtWQStK2ygUHZi3fvMeEJPQ4zGuyA3p/ghHEs0g0eBbpHIvwIVmTUNqwXuc1dY4T5 KcQ3h+5v+oSHtP/wlq0n2Vo8KXYNEuVUI6/W411c1HAER80s0TxJos+4J58loSNWzR/b YyC3nxJZ9hyuK9tnAh1tEwp6i2NDwL9ZEajeN1GFjPkq6CQOh46RwboMglKp7Ix9CorB xs5jOjKQewkg25gvcsSXAfZxiGMhlYkHO6jvXpdnznltZFCU+btuLj/3AtLoXGKE6fW+ FqlQ== X-Gm-Message-State: AHQUAuYUhbaBDJQxaOu4cjJBzWFvIKaC0f2CvYTPdVLePXVRu8xqtEto g8wpTXX3+aUAvuLH8jBuynqFpsQ7 X-Google-Smtp-Source: APXvYqzTU1Il242que4X9IsB6/6Jh56cwSlEFBZLxSmu5/gJZM1WrEypX5qyGLBCK3XZpTBygBOKgw== X-Received: by 2002:a62:2ad1:: with SMTP id q200mr586402pfq.34.1551373430059; Thu, 28 Feb 2019 09:03:50 -0800 (PST) Received: from ?IPv6:2620:15c:2c1:200:55c7:81e6:c7d8:94b? ([2620:15c:2c1:200:55c7:81e6:c7d8:94b]) by smtp.gmail.com with ESMTPSA id y6sm25507817pfy.87.2019.02.28.09.03.48 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 28 Feb 2019 09:03:48 -0800 (PST) Subject: Re: [PATCH v2] net: netem: fix skb length BUG_ON in __skb_to_sgvec To: Sheng Lan , stephen@networkplumber.org, davem@davemloft.net Cc: netdev@vger.kernel.org, netem@lists.linux-foundation.org, xuhanbing@huawei.com, zhengshaoyu@huawei.com, jiqin.ji@huawei.com, liuzhiqiang26@huawei.com, yuehaibing@huawei.com References: From: Eric Dumazet Message-ID: <87c52b93-ef66-68f3-678b-2a29f678dbbf@gmail.com> Date: Thu, 28 Feb 2019 09:03:47 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On 02/28/2019 02:47 AM, Sheng Lan wrote: > From: Sheng Lan > > It can be reproduced by following steps: > 1. virtio_net NIC is configured with gso/tso on > 2. configure nginx as http server with an index file bigger than 1M bytes > 3. use tc netem to produce duplicate packets and delay: > tc qdisc add dev eth0 root netem delay 100ms 10ms 30% duplicate 90% > 4. continually curl the nginx http server to get index file on client > 5. BUG_ON is seen quickly > ... > To fix it, netem returns NET_XMIT_SUCCESS to upper stack > when it clones a duplicate packet. > > Fixes: 35d889d1 ("sch_netem: fix skb leak in netem_enqueue()") > Signed-off-by: Sheng Lan > Reported-by: Qin Ji > Suggested-by: Eric Dumazet > > --- Signed-off-by: Eric Dumazet Thanks.