From: Vinicius Costa Gomes <vinicius.gomes@intel.com>
To: Marc Kleine-Budde <mkl@pengutronix.de>,
Tony Nguyen <anthony.l.nguyen@intel.com>
Cc: davem@davemloft.net, kuba@kernel.org, pabeni@redhat.com,
edumazet@google.com, netdev@vger.kernel.org,
sasha.neftin@intel.com, richardcochran@gmail.com,
Kurt Kanzenbach <kurt@linutronix.de>,
Naama Meir <naamax.meir@linux.intel.com>
Subject: Re: [PATCH net 3/4] igc: Retrieve TX timestamp during interrupt handling
Date: Mon, 05 Jun 2023 11:11:38 -0700 [thread overview]
Message-ID: <87cz29srs5.fsf@intel.com> (raw)
In-Reply-To: <20230605-distort-jab-ce1f3ece058a-mkl@pengutronix.de>
Marc Kleine-Budde <mkl@pengutronix.de> writes:
> On 30.05.2023 10:49:27, Tony Nguyen wrote:
>> From: Vinicius Costa Gomes <vinicius.gomes@intel.com>
>>
>> When the interrupt is handled, the TXTT_0 bit in the TSYNCTXCTL
>> register should already be set and the timestamp value already loaded
>> in the appropriate register.
>>
>> This simplifies the handling, and reduces the latency for retrieving
>> the TX timestamp, which increase the amount of TX timestamps that can
>> be handled in a given time period.
>
> What about renaming the igc_ptp_tx_work() function, as it's not
> scheduled work anymore, also IMHO you should update the function's
> comment.
Will rename the function and fix the comment for v2. Thanks.
>
> Marc
>
> --
> Pengutronix e.K. | Marc Kleine-Budde |
> Embedded Linux | https://www.pengutronix.de |
> Vertretung Nürnberg | Phone: +49-5121-206917-129 |
> Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-9 |
Cheers,
--
Vinicius
next prev parent reply other threads:[~2023-06-05 18:11 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-30 17:49 [PATCH net 0/4][pull request] igc: TX timestamping fixes Tony Nguyen
2023-05-30 17:49 ` [PATCH net 1/4] igc: Fix race condition in PTP tx code Tony Nguyen
2023-06-19 7:27 ` naamax.meir
2023-05-30 17:49 ` [PATCH net 2/4] igc: Check if hardware TX timestamping is enabled earlier Tony Nguyen
2023-06-01 6:10 ` Jakub Kicinski
2023-06-01 21:21 ` Vinicius Costa Gomes
2023-06-02 3:55 ` Jakub Kicinski
2023-06-02 17:56 ` Vinicius Costa Gomes
2023-05-30 17:49 ` [PATCH net 3/4] igc: Retrieve TX timestamp during interrupt handling Tony Nguyen
2023-06-05 11:16 ` Marc Kleine-Budde
2023-06-05 18:11 ` Vinicius Costa Gomes [this message]
2023-05-30 17:49 ` [PATCH net 4/4] igc: Add workaround for missing timestamps Tony Nguyen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87cz29srs5.fsf@intel.com \
--to=vinicius.gomes@intel.com \
--cc=anthony.l.nguyen@intel.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=kurt@linutronix.de \
--cc=mkl@pengutronix.de \
--cc=naamax.meir@linux.intel.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=richardcochran@gmail.com \
--cc=sasha.neftin@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).