* [PATCH] ath9k: remove variable sent
@ 2022-10-24 15:39 Colin Ian King
2022-10-25 9:18 ` Toke Høiland-Jørgensen
2022-11-02 15:53 ` Kalle Valo
0 siblings, 2 replies; 3+ messages in thread
From: Colin Ian King @ 2022-10-24 15:39 UTC (permalink / raw)
To: Toke Høiland-Jørgensen, Kalle Valo, David S . Miller,
Eric Dumazet, Jakub Kicinski, Paolo Abeni, linux-wireless, netdev
Cc: kernel-janitors, linux-kernel
Variable sent is just being incremented and it's never used
anywhere else. The variable and the increment are redundant so
remove it.
Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
---
drivers/net/wireless/ath/ath9k/xmit.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/net/wireless/ath/ath9k/xmit.c b/drivers/net/wireless/ath/ath9k/xmit.c
index ba271a10d4ab..39abb59d8771 100644
--- a/drivers/net/wireless/ath/ath9k/xmit.c
+++ b/drivers/net/wireless/ath/ath9k/xmit.c
@@ -1678,7 +1678,6 @@ void ath9k_release_buffered_frames(struct ieee80211_hw *hw,
struct ieee80211_tx_info *info;
struct list_head bf_q;
struct ath_buf *bf_tail = NULL, *bf = NULL;
- int sent = 0;
int i, ret;
INIT_LIST_HEAD(&bf_q);
@@ -1707,7 +1706,6 @@ void ath9k_release_buffered_frames(struct ieee80211_hw *hw,
bf_tail = bf;
nframes--;
- sent++;
TX_STAT_INC(sc, txq->axq_qnum, a_queued_hw);
if (an->sta && skb_queue_empty(&tid->retry_q))
--
2.37.3
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] ath9k: remove variable sent
2022-10-24 15:39 [PATCH] ath9k: remove variable sent Colin Ian King
@ 2022-10-25 9:18 ` Toke Høiland-Jørgensen
2022-11-02 15:53 ` Kalle Valo
1 sibling, 0 replies; 3+ messages in thread
From: Toke Høiland-Jørgensen @ 2022-10-25 9:18 UTC (permalink / raw)
To: Colin Ian King, Kalle Valo, David S . Miller, Eric Dumazet,
Jakub Kicinski, Paolo Abeni, linux-wireless, netdev
Cc: kernel-janitors, linux-kernel
Colin Ian King <colin.i.king@gmail.com> writes:
> Variable sent is just being incremented and it's never used
> anywhere else. The variable and the increment are redundant so
> remove it.
>
> Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
Acked-by: Toke Høiland-Jørgensen <toke@toke.dk>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] ath9k: remove variable sent
2022-10-24 15:39 [PATCH] ath9k: remove variable sent Colin Ian King
2022-10-25 9:18 ` Toke Høiland-Jørgensen
@ 2022-11-02 15:53 ` Kalle Valo
1 sibling, 0 replies; 3+ messages in thread
From: Kalle Valo @ 2022-11-02 15:53 UTC (permalink / raw)
To: Colin Ian King
Cc: Toke Høiland-Jørgensen, David S . Miller, Eric Dumazet,
Jakub Kicinski, Paolo Abeni, linux-wireless, netdev,
kernel-janitors, linux-kernel
Colin Ian King <colin.i.king@gmail.com> wrote:
> Variable sent is just being incremented and it's never used
> anywhere else. The variable and the increment are redundant so
> remove it.
>
> Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
> Acked-by: Toke Høiland-Jørgensen <toke@toke.dk>
> Signed-off-by: Kalle Valo <quic_kvalo@quicinc.com>
Patch applied to ath-next branch of ath.git, thanks.
4f6620cd6bbd wifi: ath9k: remove variable sent
--
https://patchwork.kernel.org/project/linux-wireless/patch/20221024153954.2168503-1-colin.i.king@gmail.com/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-11-02 15:53 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-10-24 15:39 [PATCH] ath9k: remove variable sent Colin Ian King
2022-10-25 9:18 ` Toke Høiland-Jørgensen
2022-11-02 15:53 ` Kalle Valo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).