From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id CBCF5C433EF for ; Mon, 25 Apr 2022 06:14:57 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235069AbiDYGR6 (ORCPT ); Mon, 25 Apr 2022 02:17:58 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57286 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238853AbiDYGRz (ORCPT ); Mon, 25 Apr 2022 02:17:55 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2C0F33AA7E; Sun, 24 Apr 2022 23:14:47 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id C33A3B80E00; Mon, 25 Apr 2022 06:14:45 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 6C040C385A7; Mon, 25 Apr 2022 06:14:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1650867284; bh=v1EEYhgeaIQehOy9KLNLh1/yZgwgLJde8BVe9q6sido=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=G/5U+XQ+siL3PwDWE7pVK6lRwMeGdekI4S0QO4Jgwibm4BTPBl36fOsZhdAaiUiS+ QDYwwySq/DiTevAda0978gAVWybNzmFckKkVJBlIvcPQkgLSmijnXL/3HxkR7F2axV LCJu3Vlsu+Fy0OuTCbOPZtHf9AcH24ghHQMKXxS64fZ/c6tJ4eMufpKdFrn4qb6tM6 jp6P/AQbgdRw5Ow7OM8lwuxG0XS/utCLgTSKc9t/kEEqgZCOvl4em1P8FW0j39a9+r qpbUNb5niBm3ECIm2e53Zk+pdWZ4Du4pnhdKoGnNN/9i0MJHILy7r/S8MgSxMZK//P /yoQw5eO1SGbg== From: Kalle Valo To: Abhishek Kumar Cc: linux-kernel@vger.kernel.org, linux-wireless@vger.kernel.org, briannorris@chromium.org, ath10k@lists.infradead.org, netdev@vger.kernel.org, Wen Gong , "David S. Miller" , Jakub Kicinski , Paolo Abeni Subject: Re: [PATCH] ath10k: skip ath10k_halt during suspend for driver state RESTARTING References: <20220425021442.1.I650b809482e1af8d0156ed88b5dc2677a0711d46@changeid> Date: Mon, 25 Apr 2022 09:14:37 +0300 In-Reply-To: <20220425021442.1.I650b809482e1af8d0156ed88b5dc2677a0711d46@changeid> (Abhishek Kumar's message of "Mon, 25 Apr 2022 02:15:20 +0000") Message-ID: <87czh5k7ua.fsf@kernel.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Abhishek Kumar writes: > Double free crash is observed when FW recovery(caused by wmi > timeout/crash) is followed by immediate suspend event. The FW recovery > is triggered by ath10k_core_restart() which calls driver clean up via > ath10k_halt(). When the suspend event occurs between the FW recovery, > the restart worker thread is put into frozen state until suspend completes. > The suspend event triggers ath10k_stop() which again triggers ath10k_halt() > The double invocation of ath10k_halt() causes ath10k_htt_rx_free() to be > called twice(Note: ath10k_htt_rx_alloc was not called by restart worker > thread because of its frozen state), causing the crash. > > To fix this, during the suspend flow, skip call to ath10k_halt() in > ath10k_stop() when the current driver state is ATH10K_STATE_RESTARTING. > Also, for driver state ATH10K_STATE_RESTARTING, call > ath10k_wait_for_suspend() in ath10k_stop(). This is because call to > ath10k_wait_for_suspend() is skipped later in > [ath10k_halt() > ath10k_core_stop()] for the driver state > ATH10K_STATE_RESTARTING. > > The frozen restart worker thread will be cancelled during resume when the > device comes out of suspend. > > Below is the crash stack for reference: > > [ 428.469167] ------------[ cut here ]------------ > [ 428.469180] kernel BUG at mm/slub.c:4150! > [ 428.469193] invalid opcode: 0000 [#1] PREEMPT SMP NOPTI > [ 428.469219] Workqueue: events_unbound async_run_entry_fn > [ 428.469230] RIP: 0010:kfree+0x319/0x31b > [ 428.469241] RSP: 0018:ffffa1fac015fc30 EFLAGS: 00010246 > [ 428.469247] RAX: ffffedb10419d108 RBX: ffff8c05262b0000 > [ 428.469252] RDX: ffff8c04a8c07000 RSI: 0000000000000000 > [ 428.469256] RBP: ffffa1fac015fc78 R08: 0000000000000000 > [ 428.469276] CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 > [ 428.469285] Call Trace: > [ 428.469295] ? dma_free_attrs+0x5f/0x7d > [ 428.469320] ath10k_core_stop+0x5b/0x6f > [ 428.469336] ath10k_halt+0x126/0x177 > [ 428.469352] ath10k_stop+0x41/0x7e > [ 428.469387] drv_stop+0x88/0x10e > [ 428.469410] __ieee80211_suspend+0x297/0x411 > [ 428.469441] rdev_suspend+0x6e/0xd0 > [ 428.469462] wiphy_suspend+0xb1/0x105 > [ 428.469483] ? name_show+0x2d/0x2d > [ 428.469490] dpm_run_callback+0x8c/0x126 > [ 428.469511] ? name_show+0x2d/0x2d > [ 428.469517] __device_suspend+0x2e7/0x41b > [ 428.469523] async_suspend+0x1f/0x93 > [ 428.469529] async_run_entry_fn+0x3d/0xd1 > [ 428.469535] process_one_work+0x1b1/0x329 > [ 428.469541] worker_thread+0x213/0x372 > [ 428.469547] kthread+0x150/0x15f > [ 428.469552] ? pr_cont_work+0x58/0x58 > [ 428.469558] ? kthread_blkcg+0x31/0x31 > > Signed-off-by: Abhishek Kumar > Co-developed-by: Wen Gong > Signed-off-by: Wen Gong Tested-on tag missing, but I can add it if you provide it. https://wireless.wiki.kernel.org/en/users/drivers/ath10k/submittingpatches#tested-on_tag -- https://patchwork.kernel.org/project/linux-wireless/list/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches