From: Tobias Waldekranz <tobias@waldekranz.com>
To: Vladimir Oltean <olteanv@gmail.com>
Cc: davem@davemloft.net, kuba@kernel.org, andrew@lunn.ch,
vivien.didelot@gmail.com, f.fainelli@gmail.com,
netdev@vger.kernel.org
Subject: Re: [PATCH net 2/2] net: dsa: Always react to global bridge attribute changes
Date: Sat, 06 Mar 2021 19:17:09 +0100 [thread overview]
Message-ID: <87czwcqh96.fsf@waldekranz.com> (raw)
In-Reply-To: <20210306140440.3uwmyji4smxdpgpm@skbuf>
On Sat, Mar 06, 2021 at 16:04, Vladimir Oltean <olteanv@gmail.com> wrote:
> On Sat, Mar 06, 2021 at 04:00:33PM +0200, Vladimir Oltean wrote:
>> Hi Tobias,
>>
>> On Sat, Mar 06, 2021 at 01:24:55AM +0100, Tobias Waldekranz wrote:
>> > This is the second attempt to provide a fix for the issue described in
>> > 99b8202b179f, which was reverted in the previous commit.
>> >
>> > When a change is made to some global bridge attribute, such as VLAN
>> > filtering, accept events where orig_dev is the bridge master netdev.
>> >
>> > Separate the validation of orig_dev based on whether the attribute in
>> > question is global or per-port.
>> >
>> > Fixes: 5696c8aedfcc ("net: dsa: Don't offload port attributes on standalone ports")
>> > Signed-off-by: Tobias Waldekranz <tobias@waldekranz.com>
>> > ---
>>
>> What do you think about this alternative?
>
> Ah, wait, this won't work when offloading objects/attributes on a LAG.
> Let me actually test your patch.
Right. But you made me realize that my v1 is also flawed, because it
does not guard against trying to apply attributes to non-offloaded
ports. ...the original issue :facepalm:
I have a version ready which reuses the exact predicate that you
previously added to dsa_port_offloads_netdev:
- if (netif_is_bridge_master(attr->orig_dev))
+ if (dp->bridge_dev == attr->orig_dev)
Do you think anything else needs to be changed, or should I send that as
v2?
next prev parent reply other threads:[~2021-03-06 18:17 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-06 0:24 [PATCH net 0/2] net: dsa: Avoid VLAN config corruption Tobias Waldekranz
2021-03-06 0:24 ` [PATCH net 1/2] Revert "net: dsa: fix SWITCHDEV_ATTR_ID_BRIDGE_VLAN_FILTERING getting ignored" Tobias Waldekranz
2021-03-06 0:24 ` [PATCH net 2/2] net: dsa: Always react to global bridge attribute changes Tobias Waldekranz
2021-03-06 14:00 ` Vladimir Oltean
2021-03-06 14:04 ` Vladimir Oltean
2021-03-06 18:17 ` Tobias Waldekranz [this message]
2021-03-07 0:58 ` Vladimir Oltean
2021-03-07 9:51 ` Tobias Waldekranz
2021-03-07 10:07 ` Vladimir Oltean
2021-03-06 0:41 ` [PATCH net 0/2] net: dsa: Avoid VLAN config corruption Vladimir Oltean
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87czwcqh96.fsf@waldekranz.com \
--to=tobias@waldekranz.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=olteanv@gmail.com \
--cc=vivien.didelot@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).