netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Bjørn Mork" <bjorn@mork.no>
To: Filip Moc <dev@moc6.cz>
Cc: linux-kernel@vger.kernel.org,
	"David S. Miller" <davem@davemloft.net>,
	Jakub Kicinski <kuba@kernel.org>,
	netdev@vger.kernel.org, linux-usb@vger.kernel.org
Subject: Re: [PATCH] net: usb: qmi_wwan: Set DTR quirk for MR400
Date: Tue, 17 Nov 2020 20:22:03 +0100	[thread overview]
Message-ID: <87d00bu6uc.fsf@miraculix.mork.no> (raw)
In-Reply-To: <20201117173631.GA550981@moc6.cz> (Filip Moc's message of "Tue, 17 Nov 2020 18:36:31 +0100")

Filip Moc <dev@moc6.cz> writes:

> LTE module MR400 embedded in TL-MR6400 v4 requires DTR to be set.
>
> Signed-off-by: Filip Moc <dev@moc6.cz>
> ---
>  drivers/net/usb/qmi_wwan.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/usb/qmi_wwan.c b/drivers/net/usb/qmi_wwan.c
> index afeb09b9624e..d166c321ee9b 100644
> --- a/drivers/net/usb/qmi_wwan.c
> +++ b/drivers/net/usb/qmi_wwan.c
> @@ -1047,7 +1047,7 @@ static const struct usb_device_id products[] = {
>  	{QMI_FIXED_INTF(0x05c6, 0x9011, 4)},
>  	{QMI_FIXED_INTF(0x05c6, 0x9021, 1)},
>  	{QMI_FIXED_INTF(0x05c6, 0x9022, 2)},
> -	{QMI_FIXED_INTF(0x05c6, 0x9025, 4)},	/* Alcatel-sbell ASB TL131 TDD LTE  (China Mobile) */
> +	{QMI_QUIRK_SET_DTR(0x05c6, 0x9025, 4)},	/* Alcatel-sbell ASB TL131 TDD LTE (China Mobile) */
>  	{QMI_FIXED_INTF(0x05c6, 0x9026, 3)},
>  	{QMI_FIXED_INTF(0x05c6, 0x902e, 5)},
>  	{QMI_FIXED_INTF(0x05c6, 0x9031, 5)},

Acked-by: Bjørn Mork <bjorn@mork.no>

This fix should probably go to net+stable.


Thanks,
Bjørn

  reply	other threads:[~2020-11-17 19:22 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-11-17 17:36 [PATCH] net: usb: qmi_wwan: Set DTR quirk for MR400 Filip Moc
2020-11-17 19:22 ` Bjørn Mork [this message]
2020-11-18 18:49   ` Jakub Kicinski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87d00bu6uc.fsf@miraculix.mork.no \
    --to=bjorn@mork.no \
    --cc=davem@davemloft.net \
    --cc=dev@moc6.cz \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).