netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Toke Høiland-Jørgensen" <toke@redhat.com>
To: Alexei Starovoitov <alexei.starovoitov@gmail.com>
Cc: daniel@iogearbox.net, ast@fb.com, bpf@vger.kernel.org,
	netdev@vger.kernel.org, Andrey Ignatov <rdna@fb.com>
Subject: Re: [PATCH bpf] selftests/bpf: Declare bpf_log_buf variables as static
Date: Tue, 03 Mar 2020 09:09:58 +0100	[thread overview]
Message-ID: <87d09tsvu1.fsf@toke.dk> (raw)
In-Reply-To: <20200303010311.bg6hh4ah5thu5q2c@ast-mbp>

Alexei Starovoitov <alexei.starovoitov@gmail.com> writes:

> On Mon, Mar 02, 2020 at 03:53:48PM +0100, Toke Høiland-Jørgensen wrote:
>> The cgroup selftests did not declare the bpf_log_buf variable as static, leading
>> to a linker error with GCC 10 (which defaults to -fno-common). Fix this by
>> adding the missing static declarations.
>> 
>> Fixes: 257c88559f36 ("selftests/bpf: Convert test_cgroup_attach to prog_tests")
>> Signed-off-by: Toke Høiland-Jørgensen <toke@redhat.com>
>
> Applied to bpf-next.
> It's hardly a fix. Fixes tag doesn't make it a fix in my mind.

It fixes a compile error of selftests with GCC 10; how is that not a
fix? We found it while setting up a CI test compiling Linus' tree on
Fedora rawhide, so it does happen in the wild.

> I really see no point rushing it into bpf->net->Linus's tree at this point.

Well if you're not pushing any other fixes then OK, sure, no reason to
go through the whole process just for this. But if you end up pushing
another round of fixes anyway, please include this as well. If not, I
guess we can wait :)

-Toke


  reply	other threads:[~2020-03-03  8:10 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-03-02 14:53 [PATCH bpf] selftests/bpf: Declare bpf_log_buf variables as static Toke Høiland-Jørgensen
2020-03-02 16:58 ` Andrey Ignatov
2020-03-02 17:48   ` Toke Høiland-Jørgensen
2020-03-03  1:03 ` Alexei Starovoitov
2020-03-03  8:09   ` Toke Høiland-Jørgensen [this message]
2020-03-03 16:27     ` Alexei Starovoitov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87d09tsvu1.fsf@toke.dk \
    --to=toke@redhat.com \
    --cc=alexei.starovoitov@gmail.com \
    --cc=ast@fb.com \
    --cc=bpf@vger.kernel.org \
    --cc=daniel@iogearbox.net \
    --cc=netdev@vger.kernel.org \
    --cc=rdna@fb.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).