From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 93BB1C4BA12 for ; Wed, 26 Feb 2020 13:13:02 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 54F0C20726 for ; Wed, 26 Feb 2020 13:13:02 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=cloudflare.com header.i=@cloudflare.com header.b="HfYfVZsO" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726975AbgBZNNB (ORCPT ); Wed, 26 Feb 2020 08:13:01 -0500 Received: from mail-lf1-f66.google.com ([209.85.167.66]:32976 "EHLO mail-lf1-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726764AbgBZNNB (ORCPT ); Wed, 26 Feb 2020 08:13:01 -0500 Received: by mail-lf1-f66.google.com with SMTP id n25so1969945lfl.0 for ; Wed, 26 Feb 2020 05:12:59 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cloudflare.com; s=google; h=references:user-agent:from:to:cc:subject:in-reply-to:date :message-id:mime-version; bh=VdhHrXjl+PKXd1l0Jfah9G+IGjp6vwTwBHwOu50n8sw=; b=HfYfVZsOjXxTr2vxVBObYSDTHYGkeN6N7IhqxGoU5Ok7JykNPVrPCE788nx+fjPl23 vZLT3RlQkwS4AhYagHZk7192HG7ODj0FxagKKangVWlLyW6ObJtCFRKRTRl/4UZOwGht rqBqOjEVC9cbo79bs9HABZunZYRAnJP2M3iiw= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:references:user-agent:from:to:cc:subject :in-reply-to:date:message-id:mime-version; bh=VdhHrXjl+PKXd1l0Jfah9G+IGjp6vwTwBHwOu50n8sw=; b=MDr6hX0S9MbvATUJ5psrgmss9Kk9shZZQatb9yozjDSsrc8J2NibLZ49/IM3ZIrC09 UETXjt5h1XN9Aycyl+HoSQwi4JRkt4uzW+ELIZrufHLPDSNMeSe+CEE73/aRRmu2xCJ6 2eu67fN9rk7fYIq7VviBJ9GFCFDEQ6iHbPsyc6YURvx3jDmv75k1tk/zlGo7aDt4hsMt O0rpzYT9092CTEskitCoft0aP89uCCY8VkKwC8MdXED+0nsbAr7EVaKiLvAtFKapOg0T BQuhN456uBmW2cOAcWeBB/f10Pn2nIQpdtBldjyOpZg/sY5zZaWYyA+/ZuG6XUgBOoGR GR1g== X-Gm-Message-State: APjAAAUErhzK6PwKi2RMESs+fyQREecxXk0FpCN2MAtV5csbJqcbdi7c VQAce0kE4MgyxI9s0fl6aDHsJA== X-Google-Smtp-Source: APXvYqyk12gk5w3T1MyCmjVV0V/KRRuYtatHfQg26Uspvyk9w+9w+u4vyBYFnMS6zjjSGWSUPmAmcQ== X-Received: by 2002:ac2:5a05:: with SMTP id q5mr2451450lfn.143.1582722778414; Wed, 26 Feb 2020 05:12:58 -0800 (PST) Received: from cloudflare.com ([2a02:a310:c262:aa00:b35e:8938:2c2a:ba8b]) by smtp.gmail.com with ESMTPSA id n3sm1185849ljc.100.2020.02.26.05.12.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 26 Feb 2020 05:12:57 -0800 (PST) References: <20200225135636.5768-1-lmb@cloudflare.com> <20200225135636.5768-8-lmb@cloudflare.com> User-agent: mu4e 1.1.0; emacs 26.3 From: Jakub Sitnicki To: Lorenz Bauer Cc: ast@kernel.org, daniel@iogearbox.net, john.fastabend@gmail.com, netdev@vger.kernel.org, bpf@vger.kernel.org, kernel-team@cloudflare.com Subject: Re: [PATCH bpf-next 7/7] selftests: bpf: enable UDP sockmap reuseport tests In-reply-to: <20200225135636.5768-8-lmb@cloudflare.com> Date: Wed, 26 Feb 2020 14:12:56 +0100 Message-ID: <87d0a1cx0n.fsf@cloudflare.com> MIME-Version: 1.0 Content-Type: text/plain Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Tue, Feb 25, 2020 at 02:56 PM CET, Lorenz Bauer wrote: > Remove the guard that disables UDP tests now that sockmap has support for them. > > Signed-off-by: Lorenz Bauer > --- > tools/testing/selftests/bpf/prog_tests/select_reuseport.c | 7 ------- > 1 file changed, 7 deletions(-) > > diff --git a/tools/testing/selftests/bpf/prog_tests/select_reuseport.c b/tools/testing/selftests/bpf/prog_tests/select_reuseport.c > index 68d452bb9fd9..4c09766344a4 100644 > --- a/tools/testing/selftests/bpf/prog_tests/select_reuseport.c > +++ b/tools/testing/selftests/bpf/prog_tests/select_reuseport.c > @@ -816,13 +816,6 @@ static void test_config(int sotype, sa_family_t family, bool inany) > if (!test__start_subtest(s)) > continue; > > - if (sotype == SOCK_DGRAM && > - inner_map_type != BPF_MAP_TYPE_REUSEPORT_SOCKARRAY) { > - /* SOCKMAP/SOCKHASH don't support UDP yet */ > - test__skip(); > - continue; > - } > - > setup_per_test(sotype, family, inany, t->no_inner_map); > t->fn(sotype, family); > cleanup_per_test(t->no_inner_map); This one will need a respin due to 779e422d1198 ("selftests/bpf: Run reuseport tests only with supported socket types") that landed recently in bpf-next.