From: "Bjørn Mork" <bjorn@mork.no>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: netdev@vger.kernel.org, Jeff Layton <jeff.layton@primarydata.com>,
Sedat Dilek <sedat.dilek@gmail.com>,
Johannes Berg <johannes.berg@intel.com>
Subject: Re: [PATCH v3 2/3] genetlink: disallow subscribing to unknown mcast groups
Date: Wed, 04 Feb 2015 16:36:11 +0100 [thread overview]
Message-ID: <87d25pit90.fsf@nemi.mork.no> (raw)
In-Reply-To: <87egq5uc07.fsf@nemi.mork.no> ("Bjørn Mork"'s message of "Wed, 04 Feb 2015 12:55:36 +0100")
Bjørn Mork <bjorn@mork.no> writes:
> Johannes Berg <johannes@sipsolutions.net> writes:
>
>> diff --git a/net/netlink/genetlink.c b/net/netlink/genetlink.c
>> index 2e11061ef885..c18d3f5624b2 100644
>> --- a/net/netlink/genetlink.c
>> +++ b/net/netlink/genetlink.c
>> @@ -985,7 +985,7 @@ static struct genl_multicast_group genl_ctrl_groups[] = {
>>
>> static int genl_bind(struct net *net, int group)
>> {
>> - int i, err = 0;
>> + int i, err = -ENOENT;
>>
>> down_read(&cb_lock);
>> for (i = 0; i < GENL_FAM_TAB_SIZE; i++) {
>
> This change cause serious problems for acpid, as reported on
> https://bugzilla.kernel.org/show_bug.cgi?id=92121
Ah, I see this bug is already fixed by commit 8b7c36d810c6 ("netlink:
fix wrong subscription bitmask to group mapping in"). Your change was
obviously correct, and found the long standing off by one bug. Thanks.
Sorry about the noise. I should have checked the current "net" first.
Bjørn
next prev parent reply other threads:[~2015-02-04 15:36 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-16 10:37 [PATCH v3 1/3] genetlink: document parallel_ops Johannes Berg
2015-01-16 10:37 ` [PATCH v3 2/3] genetlink: disallow subscribing to unknown mcast groups Johannes Berg
2015-01-16 22:20 ` David Miller
2015-02-04 11:55 ` Bjørn Mork
2015-02-04 15:36 ` Bjørn Mork [this message]
2015-02-04 15:43 ` Johannes Berg
2015-02-04 15:55 ` Bjørn Mork
2015-02-04 16:15 ` Bjørn Mork
2015-02-04 16:16 ` Johannes Berg
2015-01-16 10:37 ` [PATCH v3 3/3] genetlink: synchronize socket closing and family removal Johannes Berg
2015-01-16 22:20 ` David Miller
2015-01-16 22:19 ` [PATCH v3 1/3] genetlink: document parallel_ops David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87d25pit90.fsf@nemi.mork.no \
--to=bjorn@mork.no \
--cc=jeff.layton@primarydata.com \
--cc=johannes.berg@intel.com \
--cc=johannes@sipsolutions.net \
--cc=netdev@vger.kernel.org \
--cc=sedat.dilek@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).