netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Samuel Tardieu <sam@rfc1149.net>
To: netdev@vger.kernel.org
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH 01/02] net/ipv6: seperate sit driver to extra module
Date: 06 Oct 2006 13:38:24 +0200	[thread overview]
Message-ID: <87d595lln3.fsf@willow.rfc1149.net> (raw)
In-Reply-To: 20061006093402.GA12460@zlug.org

>>>>> "Joerg" == Joerg Roedel <joro-lkml@zlug.org> writes:

Joerg> this is the submit of the patch discussed yesterday to compile
Joerg> the sit driver as a seperate module.

Your patch looks ok to me, but given that many people won't need sit,
why is it enabled by default? Omitting it would save 10k of kernel
text on x86 and people will see the new kernel configuration option
anyway and will enable it if needed.

  Sam
-- 
Samuel Tardieu -- sam@rfc1149.net -- http://www.rfc1149.net/


  reply	other threads:[~2006-10-06 11:42 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-10-06  9:34 [PATCH 01/02] net/ipv6: seperate sit driver to extra module Joerg Roedel
2006-10-06 11:38 ` Samuel Tardieu [this message]
2006-10-06 11:44   ` Peter Bieringer
2006-10-06 12:09   ` Joerg Roedel
2006-10-06 12:24     ` Samuel Tardieu
2006-10-06 12:59 ` YOSHIFUJI Hideaki / 吉藤英明
2006-10-06 15:15   ` Joerg Roedel
2006-10-07  5:05     ` Bill Fink
2006-10-07  5:32       ` James Morris

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87d595lln3.fsf@willow.rfc1149.net \
    --to=sam@rfc1149.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).