Re: [PATCH net-next v3] virtio-net: page_to_skb() use build_skb when there's sufficient tailroom

[Jason Wang <jasowang@redhat.com>]

在 2021/4/20 上午10:38, Jason Wang 写道:
>>> :
>>> +    /* hdr_valid means no XDP, so we can copy the vnet header */
>>> +    if (hdr_valid) {
>>> +        hdr = skb_vnet_hdr(skb);
>>> +        memcpy(hdr, hdr_p, hdr_len);
>>
>> and hdr_p is dereferenced here.
>
>
> Right, I tend to recover the way to copy hdr and set meta just after 
> alloc/build_skb().
>
> Thanks 


Btw, since the patch modifies a critical path of virtio-net I suggest to 
test the following cases:

1) netperf TCP stream
2) netperf UDP with packet size from 64 to PAGE_SIZE
3) XDP_PASS with 1)
4) XDP_PASS with 2)
5) XDP metadata with 1)
6) XDP metadata with 2)

Thanks