From: Andrew Lunn <andrew@lunn.ch>
To: Richard Patel <ripatel@wii.dev>
Cc: intel-wired-lan@lists.osuosl.org,
Tony Nguyen <anthony.l.nguyen@intel.com>,
Przemek Kitszel <przemyslaw.kitszel@intel.com>,
Andrew Lunn <andrew+netdev@lunn.ch>,
Steve Douthit <stephend@silicom-usa.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ixgbe: fix MDIO bus leak when rejecting SFP module
Date: Wed, 26 Aug 2026 14:23:25 +0200 [thread overview]
Message-ID: <87e4aa92-4687-4fbf-b632-9493932c349f@lunn.ch> (raw)
In-Reply-To: <20260826042945.2344686-1-ripatel@wii.dev>
On Wed, Aug 26, 2026 at 04:29:45AM +0000, Richard Patel wrote:
> Plugging in an unsupported SFP module caused ixgbe NICs to get
> wedged permanently.
>
> ixgbe unregisters the netdev when rejecting an SFP transceiver as
> unsupported.
>
> ixgbe 0000:3b:00.0: failed to initialize because an unsupported SFP+ module type was detected.
> ixgbe 0000:3b:00.0: Reload the driver after installing a supported module.
> ixgbe 0000:3b:00.0: removed PHC on enp59s0
>
> This code path failed to unregister an MDIO bus owned by that
> netdev, so when unregister_netdev() tries to tear it down
> (via device_del() -> devres_release_all() -> mdiobus_free()),
> it trips over the leaked registration.
Maybe look at using devm_mdiobus_register()?
Andrew
next prev parent reply other threads:[~2026-08-26 12:23 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-26 4:29 [PATCH] ixgbe: fix MDIO bus leak when rejecting SFP module Richard Patel
2026-08-26 12:23 ` Andrew Lunn [this message]
2026-08-26 18:27 ` Richard Patel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87e4aa92-4687-4fbf-b632-9493932c349f@lunn.ch \
--to=andrew@lunn.ch \
--cc=andrew+netdev@lunn.ch \
--cc=anthony.l.nguyen@intel.com \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=przemyslaw.kitszel@intel.com \
--cc=ripatel@wii.dev \
--cc=stephend@silicom-usa.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox