Re: [PATCH net-next 0/2] ipv4: Remove netns argument from fib_table_lookup()

["Björn Töpel" <bjorn@kernel.org>]

Ido Schimmel <idosch@nvidia.com> writes:

> Commit c436a624f89e ("ipv4: Pass netns to fib_table_lookup()") added the
> network namespace as an argument of fib_table_lookup() so that it could
> be passed to the fib_table_lookup tracepoint. As noted by Paolo [1], the
> function is called in the data path where the additional argument is
> unnecessary overhead, as the namespace is only needed when the
> tracepoint is enabled.
>
> This patchset stores the namespace in the FIB table instead and passes
> it from there to the tracepoint, so that the namespace is only read when
> the tracepoint is enabled. The tracepoint itself is unchanged.
>
> Patch #1 stores the namespace in the FIB table.
>
> Patch #2 passes the namespace from the FIB table to the tracepoint and
> reverts the signature of fib_table_lookup() and its callers to what they
> were before the above commit.
>
> No functional changes intended.
>
> [1] https://lore.kernel.org/netdev/43857d08-c4f4-44ce-a0b3-0e7fcc56bf90@redhat.com/
>
> Ido Schimmel (2):
>   ipv4: Store netns in FIB table
>   ipv4: Do not pass netns to fib_table_lookup()

For the series:

Tested-by: Björn Töpel <bjorn@kernel.org>
Reviewed-by: Björn Töpel <bjorn@kernel.org>