From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ed1-f50.google.com (mail-ed1-f50.google.com [209.85.208.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CE737366057 for ; Thu, 5 Mar 2026 10:40:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.50 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772707232; cv=none; b=dO5BFjW0h5ZCHkZBaNgaLKzKMU22PlATia5rVGoLUOB7tMOYzmAO0YBYYfYr158oq1eqnrsmNWbjY3Otkm9DyfxuY71xioVpxqhUTOkBbygnMilpi5fvtnpG9MEt/Ws4KlLI43TdYeUlc/iVxQL5caizTVzCDeLtS2A8bWw7AYc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772707232; c=relaxed/simple; bh=pMXAPz6rRpIt0TmYV3UYgAGQEEmHwHzSHA9H7ONKRgE=; h=From:To:Cc:Subject:In-Reply-To:References:Date:Message-ID: MIME-Version:Content-Type; b=ayyGPrigzQZOjrJOk5EbhtMKfoDGMwRRINx7vdphvMGnEOwRgP/1U2P4+BtkjMMTfzVLDJIdeCeNl2qHxh0e19FaHRCXmk3xfFMmdrdGR3zlgKUVDb0acvXoM2xJ/c3wkfM1NBTdw0lGcFBpkmiNKVBNmhYvUQRv+Szvo62lWPA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=cloudflare.com; spf=pass smtp.mailfrom=cloudflare.com; dkim=pass (2048-bit key) header.d=cloudflare.com header.i=@cloudflare.com header.b=duvo3kHf; arc=none smtp.client-ip=209.85.208.50 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=cloudflare.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=cloudflare.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=cloudflare.com header.i=@cloudflare.com header.b="duvo3kHf" Received: by mail-ed1-f50.google.com with SMTP id 4fb4d7f45d1cf-660a293515fso5729365a12.1 for ; Thu, 05 Mar 2026 02:40:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cloudflare.com; s=google09082023; t=1772707229; x=1773312029; darn=vger.kernel.org; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:from:to:cc:subject:date:message-id:reply-to; bh=OmEEWEe7hw50EcSRskP7Ho2A43L76NQ2PK5yFgjRUKk=; b=duvo3kHf2pqNHkWqet8xy4Kc5DBBG0/8uecQa7ids7UqABS7u3OlzI/cTMFVJRnE+R 0JnlT5olx7uxwkNSsOZVpaQ9TDHL2cf1YqczwJ+9cmOuGQTIDe0N1gsd1nx+ay/kLYH+ /3gTpeQxoEQ4bdRtFAXHY9vHjsGx6XWxyltJ4P6OpxeU+7ZWVGRZhGj8/MMZDqhDeyll vMO6SL5TAshultlByEemdDLoAK38+gtLPYt5nvybBpD7Ofv5WWceyf+Hhizq3qsKNdF/ CpMzcf2QkpnVBrXSMJ/BzULujslbk5m7S/mZAsOKwos58fz2bpY/V0sKYcq9cm7FHudx NtCw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772707229; x=1773312029; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=OmEEWEe7hw50EcSRskP7Ho2A43L76NQ2PK5yFgjRUKk=; b=rmDa3V8V/jNVICmNv96RWYH1M5GOa8Q+kDqhJ6FEN3IQZwpfmsLituYWJdPyHGpCC+ vhwqYfCE6zsEPJGRPIhfhzpF4FWq1tKJBayY9bQmkHV0+yNrejiz3xrv5ldt1R17ctjC ujVVqQvZ5Dj3cDw5C9xp4aGAnmI3yCQ5Ow8IwvKLslw5t1XVxcwZoNmHyMEgt0XKiYni fXRJ6F3Idrqtm/y12ZnsIMusChbIYE5Rt02CJBS5NgTlUbu7ZBrlLEyh6nmWkrhkZ9v6 WrgmqYxCX5HTK1x0GWS0C6wLKaqBpLNtz3mo9RZAxGeKXSKodtN673AiZvWEuMcDQKVL BPXA== X-Forwarded-Encrypted: i=1; AJvYcCUTPQjEWaMkSywfmMlhnTfK6RzMs4XDUusINALYv1x54ICOVa7NzNpvJPS+mwgl+5Hb2nvdPuM=@vger.kernel.org X-Gm-Message-State: AOJu0YwZJXUtk4P972hlJiaJWBbdDtFINIryYkJE1zWm0zUykpz1kJ5R W7UmoD5nBT8M/vBHbiqFE+peg/DjCimxO/DhzbcKAEtZYZZhdWjPdnfigB9y8z/C2Nd5YUIRrU0 DHdvt1Cgf2w== X-Gm-Gg: ATEYQzzoSiJvvihRzfyVQLeApx3XBYK9NXyhq5weQEtrfduFQ85LfjdF1ll+jL6IclH U82s1T+4BBqF79IesuL8KXRcefZYxFftwkgE4j5KFDf6nKxDz/pVhJAMeU7N0Onk8Z9yLCqXo7y dsYdSfdBBy5qiLK+M4AAo+vBk6W0RppWyxKm7WsqDRqKM8LkFK/dOzs9bHAbJuux2pZzEcgTZiG rC6MRk4TRAIQ1ybgf6wmjrIOG6IX2wpMqRp5nLRZv027zK7VUmhyIP2x1QQllVD7Igzwg/bQKGO fC1/HEg/dql2NFP1dFz3P/b/4nHcqyx0MXf9zml8GW3zbtS2X05bFyvn15EY2+d+d+OIw/9qpkx HRp0iXcM8R0AHcwIKAG46clUgX74D6c+5oitLD7AXXje0znVT2Nbbcvzyb/r/FGrKaxR8MX2RMz IMzgM+b7CObtyq1Xu89EgD+B5J2NPdl2zPYc26NlkbAc7xld+amy6IXUp7B1uOATZt2GRGrr56v TMchsrL X-Received: by 2002:a17:907:7f86:b0:b90:1088:6c54 with SMTP id a640c23a62f3a-b93f146710dmr305133166b.34.1772707229102; Thu, 05 Mar 2026 02:40:29 -0800 (PST) Received: from cloudflare.com (79.184.124.63.ipv4.supernova.orange.pl. [79.184.124.63]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b935ab13558sm914137766b.5.2026.03.05.02.40.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 05 Mar 2026 02:40:28 -0800 (PST) From: Jakub Sitnicki To: Keita Morisaki Cc: Eric Dumazet , Neal Cardwell , "David S . Miller" , David Ahern , Jakub Kicinski , Paolo Abeni , Kuniyuki Iwashima , Simon Horman , netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH net-next] tcp: remove unused hash_size from struct tcp_out_options In-Reply-To: <20260305022703.3946470-1-kmta1236@gmail.com> (Keita Morisaki's message of "Thu, 5 Mar 2026 11:27:03 +0900") References: <20260305022703.3946470-1-kmta1236@gmail.com> Date: Thu, 05 Mar 2026 11:40:27 +0100 Message-ID: <87eclyo8ys.fsf@cloudflare.com> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain On Thu, Mar 05, 2026 at 11:27 AM +09, Keita Morisaki wrote: > hash_size is declared but never read. The MD5 path always uses a > fixed size of 16, and the TCP-AO path uses tcp_ao_maclen(). > > Suggested-by: Jakub Sitnicki > Signed-off-by: Keita Morisaki > --- > net/ipv4/tcp_output.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/net/ipv4/tcp_output.c b/net/ipv4/tcp_output.c > index 63ee037f46e50..f0e04ebd8b723 100644 > --- a/net/ipv4/tcp_output.c > +++ b/net/ipv4/tcp_output.c > @@ -441,7 +441,6 @@ struct tcp_out_options { > u8 ws; /* window scale, 0 to disable */ > u8 num_accecn_fields:7, /* number of AccECN fields needed */ > use_synack_ecn_bytes:1; /* Use synack_ecn_bytes or not */ > - u8 hash_size; /* bytes in hash_location */ > __u8 *hash_location; /* temporary pointer, overloaded */ > __u32 tsval, tsecr; /* need to include OPTION_TS */ > struct tcp_fastopen_cookie *fastopen_cookie; /* Fast open cookie */ > > base-commit: 21fc6b53f12379f3f9b29830be3597a322261df8 Worth noting that this closes a 7-byte hole we had there: u8 num_accecn_fields:7; /* 7: 0 1 */ u8 use_synack_ecn_bytes:1; /* 7: 7 1 */ u8 hash_size; /* 8 1 */ /* XXX 7 bytes hole, try to pack */ __u8 * hash_location; /* 16 8 */ Struct size went down from 96B to 88B.