From: "Toke Høiland-Jørgensen" <toke@redhat.com>
To: Martin KaFai Lau <kafai@fb.com>
Cc: andrii@kernel.org, ast@kernel.org, bpf@vger.kernel.org,
daniel@iogearbox.net, davem@davemloft.net, hawk@kernel.org,
john.fastabend@gmail.com, kpsingh@kernel.org, kuba@kernel.org,
linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
songliubraving@fb.com, syzkaller-bugs@googlegroups.com,
yhs@fb.com,
syzbot <syzbot+0e91362d99386dc5de99@syzkaller.appspotmail.com>
Subject: Re: [syzbot] BUG: missing reserved tailroom
Date: Thu, 10 Mar 2022 22:57:52 +0100 [thread overview]
Message-ID: <87ee39xyfz.fsf@toke.dk> (raw)
In-Reply-To: <20220310210626.25o2mll3jmp62swy@kafai-mbp.dhcp.thefacebook.com>
Martin KaFai Lau <kafai@fb.com> writes:
> On Thu, Mar 10, 2022 at 10:37:20AM -0800, syzbot wrote:
>> Hello,
>>
>> syzbot found the following issue on:
>>
>> HEAD commit: de55c9a1967c Merge branch 'Add support for transmitting pa..
>> git tree: bpf-next
>> console output: https://syzkaller.appspot.com/x/log.txt?x=14ce88ad700000
>> kernel config: https://syzkaller.appspot.com/x/.config?x=2fa13781bcea50fc
>> dashboard link: https://syzkaller.appspot.com/bug?extid=0e91362d99386dc5de99
>> compiler: gcc (Debian 10.2.1-6) 10.2.1 20210110, GNU ld (GNU Binutils for Debian) 2.35.2
>> syz repro: https://syzkaller.appspot.com/x/repro.syz?x=11f36345700000
>> C reproducer: https://syzkaller.appspot.com/x/repro.c?x=14c8ca65700000
>>
>> The issue was bisected to:
>>
>> commit b530e9e1063ed2b817eae7eec6ed2daa8be11608
>> Author: Toke Høiland-Jørgensen <toke@redhat.com>
>> Date: Wed Mar 9 10:53:42 2022 +0000
>>
>> bpf: Add "live packet" mode for XDP in BPF_PROG_RUN
>>
>> bisection log: https://syzkaller.appspot.com/x/bisect.txt?x=17696e55700000
>> final oops: https://syzkaller.appspot.com/x/report.txt?x=14e96e55700000
>> console output: https://syzkaller.appspot.com/x/log.txt?x=10e96e55700000
>>
>> IMPORTANT: if you fix the issue, please add the following tag to the commit:
>> Reported-by: syzbot+0e91362d99386dc5de99@syzkaller.appspotmail.com
>> Fixes: b530e9e1063e ("bpf: Add "live packet" mode for XDP in BPF_PROG_RUN")
>>
>> ------------[ cut here ]------------
>> XDP_WARN: xdp_update_frame_from_buff(line:274): Driver BUG: missing reserved tailroom
>> WARNING: CPU: 0 PID: 3590 at net/core/xdp.c:599 xdp_warn+0x28/0x30 net/core/xdp.c:599
> Toke, please take a look.
Right, I see the problem; will send a fix!
-Toke
prev parent reply other threads:[~2022-03-10 21:58 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-10 18:37 [syzbot] BUG: missing reserved tailroom syzbot
2022-03-10 21:06 ` Martin KaFai Lau
2022-03-10 21:57 ` Toke Høiland-Jørgensen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ee39xyfz.fsf@toke.dk \
--to=toke@redhat.com \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=hawk@kernel.org \
--cc=john.fastabend@gmail.com \
--cc=kafai@fb.com \
--cc=kpsingh@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=songliubraving@fb.com \
--cc=syzbot+0e91362d99386dc5de99@syzkaller.appspotmail.com \
--cc=syzkaller-bugs@googlegroups.com \
--cc=yhs@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).