From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A6B77C433EF for ; Thu, 10 Mar 2022 21:58:20 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1344194AbiCJV7U (ORCPT ); Thu, 10 Mar 2022 16:59:20 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41292 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1344190AbiCJV7S (ORCPT ); Thu, 10 Mar 2022 16:59:18 -0500 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 0DD4EF65F6 for ; Thu, 10 Mar 2022 13:58:15 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1646949492; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=wyYbSMNDIkgLbz7yvi2HvYsU8igcLdYIMzghnDnn36s=; b=UidHk63UgkJF2SOSl3S9O9VQmuBSt10ccNEJJUW9Z8w+hABOCnDw5JZBIuyuQkf41Uvb66 xGMmOPiVyE3RQLOusjS4igcoNHwmPqupWDuLrZEogl60O0IIPd3k5g7Q03mYDMCS8/a3dp Xi4HcaPn2QpjsT/V8Ve12r0c4nntL+k= Received: from mail-ed1-f69.google.com (mail-ed1-f69.google.com [209.85.208.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-459-laLECiGuNXqglYKZW3UsiQ-1; Thu, 10 Mar 2022 16:57:58 -0500 X-MC-Unique: laLECiGuNXqglYKZW3UsiQ-1 Received: by mail-ed1-f69.google.com with SMTP id z19-20020a50cd13000000b0041693869e9aso3635007edi.14 for ; Thu, 10 Mar 2022 13:57:58 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:in-reply-to:references:date :message-id:mime-version:content-transfer-encoding; bh=wyYbSMNDIkgLbz7yvi2HvYsU8igcLdYIMzghnDnn36s=; b=GbKXZVrfNBamk+NltGSrgg4pdtmV1BtbhNz5WdRvgSsNtApoAP68lL84Womh52mJWA 1tsx1soXgBBMXGVyHzdp2u+tktgaczsm/oIIZENQE12p3RfLiGmKQru4BMSow9t0NwXJ Qni3cv+LzB8Og/nswhtSIdOQaIiTJG5xNnOHXfO/88NSXFRXf6tc9XueEexUD9yfr9UY QXn3qW6UygG9H99gICJdX6NlJctPX49W1hkx+g2p+BjsayzuwO9MR+7QHtZQNNZXhhOF POXcTVpxf6Py2IhdqZV1xNlPWW2wb5IcQUnspZI9yVfFXiOnKkrNKa1CuSHYGdYR0V6v VPDQ== X-Gm-Message-State: AOAM53290ALfKHo5eEE0dd/GZF453R9GQrOBKufxy9xyRaTz4Fb02Zm4 9cQr2dTdkm/gaYj8xPiHd8Q3cdmXEP/lx4YElaqus2WOxt0uBEAzy4hddhMgFljuByRmZilI/Zc HI/MUZX7XSns7PpUB X-Received: by 2002:a05:6402:34cb:b0:415:b974:ec5c with SMTP id w11-20020a05640234cb00b00415b974ec5cmr6424355edc.329.1646949474988; Thu, 10 Mar 2022 13:57:54 -0800 (PST) X-Google-Smtp-Source: ABdhPJx3J07rWqPVHpRbRgAfNIsa2YEkK9fYYXo5WB/bsFY89DjXNQc74Jsib2unZpspwGd+tFoaoQ== X-Received: by 2002:a05:6402:34cb:b0:415:b974:ec5c with SMTP id w11-20020a05640234cb00b00415b974ec5cmr6424283edc.329.1646949473831; Thu, 10 Mar 2022 13:57:53 -0800 (PST) Received: from alrua-x1.borgediget.toke.dk ([2a0c:4d80:42:443::2]) by smtp.gmail.com with ESMTPSA id g16-20020a170906521000b006d58773e992sm2222909ejm.188.2022.03.10.13.57.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 10 Mar 2022 13:57:53 -0800 (PST) Received: by alrua-x1.borgediget.toke.dk (Postfix, from userid 1000) id 74D661A8990; Thu, 10 Mar 2022 22:57:52 +0100 (CET) From: Toke =?utf-8?Q?H=C3=B8iland-J=C3=B8rgensen?= To: Martin KaFai Lau Cc: andrii@kernel.org, ast@kernel.org, bpf@vger.kernel.org, daniel@iogearbox.net, davem@davemloft.net, hawk@kernel.org, john.fastabend@gmail.com, kpsingh@kernel.org, kuba@kernel.org, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, songliubraving@fb.com, syzkaller-bugs@googlegroups.com, yhs@fb.com, syzbot Subject: Re: [syzbot] BUG: missing reserved tailroom In-Reply-To: <20220310210626.25o2mll3jmp62swy@kafai-mbp.dhcp.thefacebook.com> References: <00000000000019c51e05d9e18158@google.com> <20220310210626.25o2mll3jmp62swy@kafai-mbp.dhcp.thefacebook.com> X-Clacks-Overhead: GNU Terry Pratchett Date: Thu, 10 Mar 2022 22:57:52 +0100 Message-ID: <87ee39xyfz.fsf@toke.dk> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Martin KaFai Lau writes: > On Thu, Mar 10, 2022 at 10:37:20AM -0800, syzbot wrote: >> Hello, >>=20 >> syzbot found the following issue on: >>=20 >> HEAD commit: de55c9a1967c Merge branch 'Add support for transmitting = pa.. >> git tree: bpf-next >> console output: https://syzkaller.appspot.com/x/log.txt?x=3D14ce88ad7000= 00 >> kernel config: https://syzkaller.appspot.com/x/.config?x=3D2fa13781bcea= 50fc >> dashboard link: https://syzkaller.appspot.com/bug?extid=3D0e91362d99386d= c5de99 >> compiler: gcc (Debian 10.2.1-6) 10.2.1 20210110, GNU ld (GNU Binut= ils for Debian) 2.35.2 >> syz repro: https://syzkaller.appspot.com/x/repro.syz?x=3D11f3634570= 0000 >> C reproducer: https://syzkaller.appspot.com/x/repro.c?x=3D14c8ca657000= 00 >>=20 >> The issue was bisected to: >>=20 >> commit b530e9e1063ed2b817eae7eec6ed2daa8be11608 >> Author: Toke H=C3=B8iland-J=C3=B8rgensen >> Date: Wed Mar 9 10:53:42 2022 +0000 >>=20 >> bpf: Add "live packet" mode for XDP in BPF_PROG_RUN >>=20 >> bisection log: https://syzkaller.appspot.com/x/bisect.txt?x=3D17696e557= 00000 >> final oops: https://syzkaller.appspot.com/x/report.txt?x=3D14e96e557= 00000 >> console output: https://syzkaller.appspot.com/x/log.txt?x=3D10e96e557000= 00 >>=20 >> IMPORTANT: if you fix the issue, please add the following tag to the com= mit: >> Reported-by: syzbot+0e91362d99386dc5de99@syzkaller.appspotmail.com >> Fixes: b530e9e1063e ("bpf: Add "live packet" mode for XDP in BPF_PROG_RU= N") >>=20 >> ------------[ cut here ]------------ >> XDP_WARN: xdp_update_frame_from_buff(line:274): Driver BUG: missing rese= rved tailroom >> WARNING: CPU: 0 PID: 3590 at net/core/xdp.c:599 xdp_warn+0x28/0x30 net/c= ore/xdp.c:599 > Toke, please take a look. Right, I see the problem; will send a fix! -Toke