From: "Toke Høiland-Jørgensen" <toke@redhat.com>
To: Lorenzo Bianconi <lorenzo@kernel.org>, andriin@fb.com
Cc: bpf@vger.kernel.org, netdev@vger.kernel.org,
Jesper Dangaard Brouer <brouer@redhat.com>,
David Miller <davem@davemloft.net>,
ast@kernel.org
Subject: Re: xdp generic default option
Date: Wed, 19 Aug 2020 16:39:47 +0200 [thread overview]
Message-ID: <87eeo2pumk.fsf@toke.dk> (raw)
In-Reply-To: <20200819092811.GA2420@lore-desk>
Lorenzo Bianconi <lorenzo@kernel.org> writes:
> Hi Andrii,
>
> working on xdp multi-buff I figured out now xdp generic is the default choice
> if not specified by userspace. In particular after commit 7f0a838254bd
> ("bpf, xdp: Maintain info on attached XDP BPF programs in net_device"), running
> the command below, XDP will run in generic mode even if the underlay driver
> support XDP in native mode:
>
> $ip link set dev eth0 xdp obj prog.o
> $ip link show dev eth0
> 2: eth0: <BROADCAST,MULTICAST,UP,LOWER_UP> mtu 1500 xdpgeneric qdisc mq state UP mode DEFAULT
> group default qlen 1024
> link/ether f0:ad:4e:09:6b:57 brd ff:ff:ff:ff:ff:ff
> prog/xdp id 1 tag 3b185187f1855c4c jited
Yeah, defaulting to xdpgeneric is not a good idea (and a change in
behaviour; I get native mode on the same command on a 5.8 kernel)...
-Toke
next prev parent reply other threads:[~2020-08-19 14:39 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-19 9:28 xdp generic default option Lorenzo Bianconi
2020-08-19 14:39 ` Toke Høiland-Jørgensen [this message]
2020-08-19 19:07 ` Jakub Kicinski
2020-08-19 20:57 ` Andrii Nakryiko
2020-08-20 8:25 ` Jesper Dangaard Brouer
2020-08-20 14:00 ` David Ahern
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87eeo2pumk.fsf@toke.dk \
--to=toke@redhat.com \
--cc=andriin@fb.com \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=brouer@redhat.com \
--cc=davem@davemloft.net \
--cc=lorenzo@kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).