From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DA592C433E0 for ; Wed, 27 May 2020 23:28:18 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id B637C2084C for ; Wed, 27 May 2020 23:28:18 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725841AbgE0X2S (ORCPT ); Wed, 27 May 2020 19:28:18 -0400 Received: from mga14.intel.com ([192.55.52.115]:5300 "EHLO mga14.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725267AbgE0X2R (ORCPT ); Wed, 27 May 2020 19:28:17 -0400 IronPort-SDR: 86b2vKlgJpBy7nFXMF2ZtIcz82i47YQmpRMq2BY+OS6zNjfYV9xn4xGQW5g2Qiobu7V+IouFmk XFaBXWi0r0RA== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 27 May 2020 16:28:17 -0700 IronPort-SDR: ymWlNhG63YMw460FI2bhH3CSGRN0fjZDHCO10avwA3is357mE41AFiDVBZAN9wsL/9moOXXoK9 tOpF6kFiZrgw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.73,442,1583222400"; d="scan'208";a="468921730" Received: from unknown (HELO ellie) ([10.212.136.193]) by fmsmga006.fm.intel.com with ESMTP; 27 May 2020 16:28:17 -0700 From: Vinicius Costa Gomes To: Vladimir Oltean , davem@davemloft.net Cc: andrew@lunn.ch, f.fainelli@gmail.com, vivien.didelot@gmail.com, netdev@vger.kernel.org Subject: Re: [PATCH v2 net-next] net: dsa: sja1105: offload the Credit-Based Shaper qdisc In-Reply-To: <20200527203850.1354202-1-olteanv@gmail.com> References: <20200527203850.1354202-1-olteanv@gmail.com> Date: Wed, 27 May 2020 16:28:17 -0700 Message-ID: <87eer5j6um.fsf@intel.com> MIME-Version: 1.0 Content-Type: text/plain Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Vladimir Oltean writes: > From: Vladimir Oltean > > SJA1105, being AVB/TSN switches, provide hardware assist for the > Credit-Based Shaper as described in the IEEE 8021Q-2018 document. > > First generation has 10 shapers, freely assignable to any of the 4 > external ports and 8 traffic classes, and second generation has 16 > shapers. > > We also need to provide a dummy implementation of mqprio qdisc offload, > since this seems to be necessary for shaping any traffic class other > than zero. This is false, right? Cheers, -- Vinicius