From: Vinicius Costa Gomes <vinicius.gomes@intel.com>
To: David Miller <davem@davemloft.net>
Cc: netdev@vger.kernel.org, jhs@mojatatu.com,
xiyou.wangcong@gmail.com, jiri@resnulli.us,
vladimir.oltean@nxp.com, po.liu@nxp.com
Subject: Re: [PATCH net v2 2/3] taprio: Allow users not to specify "flags" when changing schedules
Date: Wed, 29 Jan 2020 10:13:22 -0800 [thread overview]
Message-ID: <87eevicerh.fsf@linux.intel.com> (raw)
In-Reply-To: <20200129.111245.1611718557356636170.davem@davemloft.net>
David Miller <davem@davemloft.net> writes:
> From: Vinicius Costa Gomes <vinicius.gomes@intel.com>
> Date: Tue, 28 Jan 2020 15:52:26 -0800
>
>> When any offload mode is enabled, users had to specify the
>> "flags" parameter when adding a new "admin" schedule.
>>
>> This fix allows that parameter to be omitted when adding a new
>> schedule.
>>
>> This will make that we have one source of truth for 'flags'.
>>
>> Fixes: 4cfd5779bd6e ("taprio: Add support for txtime-assist mode")
>> Signed-off-by: Vinicius Costa Gomes <vinicius.gomes@intel.com>
>> Acked-by: Vladimir Oltean <vladimir.oltean@nxp.com>
>
> This will visibly change behavior for a feature in a released
> kernel (v5.3 and later) and it means that newer tools will do
> things that don't work in older kernels.
>
> I think your opportunity to adjust these semantics, has therefore,
> long passed.
Understood. Another lesson learned.
I'll need to send another version then. This semantic change have
creeped up to the "rcu stall" fix.
Cheers,
--
Vinicius
next prev parent reply other threads:[~2020-01-29 18:12 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-28 23:52 [PATCH net v2 0/3] taprio: Some fixes Vinicius Costa Gomes
2020-01-28 23:52 ` [PATCH net v2 1/3] taprio: Fix enabling offload with wrong number of traffic classes Vinicius Costa Gomes
2020-01-29 10:11 ` David Miller
2020-01-31 18:05 ` Vinicius Costa Gomes
2020-01-28 23:52 ` [PATCH net v2 2/3] taprio: Allow users not to specify "flags" when changing schedules Vinicius Costa Gomes
2020-01-29 10:12 ` David Miller
2020-01-29 11:24 ` Vladimir Oltean
2020-01-29 12:09 ` David Miller
2020-01-29 12:23 ` Vladimir Oltean
2020-01-29 18:13 ` Vinicius Costa Gomes [this message]
2020-01-28 23:52 ` [PATCH net v2 3/3] taprio: Fix still allowing changing the flags during runtime Vinicius Costa Gomes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87eevicerh.fsf@linux.intel.com \
--to=vinicius.gomes@intel.com \
--cc=davem@davemloft.net \
--cc=jhs@mojatatu.com \
--cc=jiri@resnulli.us \
--cc=netdev@vger.kernel.org \
--cc=po.liu@nxp.com \
--cc=vladimir.oltean@nxp.com \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).