netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: ebiederm@xmission.com (Eric W. Biederman)
To: David Miller <davem@davemloft.net>
Cc: rshearma@brocade.com, netdev@vger.kernel.org,
	Roopa Prabhu <roopa@cumulusnetworks.com>
Subject: [PATCH net-next] mpls: Don't accept multipath configuration until the support is complete
Date: Mon, 02 Nov 2015 13:29:17 -0600	[thread overview]
Message-ID: <87egg8ryia.fsf@x220.int.ebiederm.org> (raw)
In-Reply-To: <1446133748-13738-1-git-send-email-roopa@cumulusnetworks.com> (Roopa Prabhu's message of "Thu, 29 Oct 2015 08:49:08 -0700")


Currently the multipath code has a nasty failure mode in that it will
fail to notice link down or administrative device down and will
instead black hole packets instead of sending them to their nexthop
destination.

Half the point of multipath is to gracefully handle forwarding path
failures and as the current code does not handle forwarding failures the
current code is dangerous to use.

As mpls multipath has never been exported to userspace and as the
implementation was not complete before the merge window disable the mpls
multipath code by rejecting all multipath configuration requests.  This
will give us another kernel development cycle to cleanly sort out the
issues, without any bad precedents to worry about.

Signed-off-by: "Eric W. Biederman" <ebiederm@xmission.com>
---
 net/mpls/af_mpls.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/net/mpls/af_mpls.c b/net/mpls/af_mpls.c
index c70d750148b6..893cd2dc3979 100644
--- a/net/mpls/af_mpls.c
+++ b/net/mpls/af_mpls.c
@@ -1162,6 +1162,8 @@ static int rtm_to_route_config(struct sk_buff *skb,  struct nlmsghdr *nlh,
 		{
 			cfg->rc_mp = nla_data(nla);
 			cfg->rc_mp_len = nla_len(nla);
+			/* Fail until multipath support is complete */
+			goto errout;
 			break;
 		}
 		default:
-- 
2.2.1

  parent reply	other threads:[~2015-11-02 19:37 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-10-29 15:49 [PATCH net-next RFC] mpls: support for dead routes Roopa Prabhu
2015-10-29 16:53 ` Robert Shearman
2015-10-29 18:46   ` roopa
2015-10-30 15:06     ` Robert Shearman
2015-11-01 21:24       ` Eric W. Biederman
2015-11-01 21:27 ` Eric W. Biederman
2015-11-02  1:01   ` roopa
2015-11-02  5:08     ` Eric W. Biederman
2015-11-02 21:18       ` roopa
2015-11-02 19:29 ` Eric W. Biederman [this message]
2015-11-02 19:49   ` [PATCH net-next] mpls: Don't accept multipath configuration until the support is complete Sergei Shtylyov
2015-11-03  6:09     ` Eric W. Biederman
2015-11-03 14:03       ` roopa
2015-11-03 15:14         ` Robert Shearman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87egg8ryia.fsf@x220.int.ebiederm.org \
    --to=ebiederm@xmission.com \
    --cc=davem@davemloft.net \
    --cc=netdev@vger.kernel.org \
    --cc=roopa@cumulusnetworks.com \
    --cc=rshearma@brocade.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).