From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dan Smith Subject: Re: [PATCH 2/2] [RFC] Add c/r support for connected INET sockets Date: Wed, 07 Oct 2009 10:22:26 -0700 Message-ID: <87eipff7al.fsf@caffeine.danplanet.com> References: <1254932945-12578-1-git-send-email-danms@us.ibm.com> <1254932945-12578-3-git-send-email-danms@us.ibm.com> <20091007171907.GA20572@us.ibm.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: containers-qjLDD68F18O7TbgM5vRIOg@public.gmane.org, John Dykstra , netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: "Serge E. Hallyn" Return-path: In-Reply-To: <20091007171907.GA20572-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org> (Serge E. Hallyn's message of "Wed\, 7 Oct 2009 12\:19\:07 -0500") List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: containers-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org Errors-To: containers-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org List-Id: netdev.vger.kernel.org >> + CKPT_COPY(op, hh->daddr, sk->daddr); >> + CKPT_COPY(op, hh->rcv_saddr, sk->rcv_saddr); >> + CKPT_COPY(op, hh->dport, sk->dport); >> + CKPT_COPY(op, hh->num, sk->num); >> + CKPT_COPY(op, hh->saddr, sk->saddr); >> + CKPT_COPY(op, hh->sport, sk->sport); SH> This becomes an easy way around CAP_NET_BIND_SERVICE right? Or SH> will that be caught by something already done in your listen patch SH> after this step? Actually, yeah, you're right. I was going to say that we'd catch it because we also do a bind(), but there's no guarantee that the sockaddr_in we use for bind() is the same as this :D -- Dan Smith IBM Linux Technology Center email: danms-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org