Netdev List
 help / color / mirror / Atom feed
From: kovalev@altlinux.org
To: Greg KH <greg@kroah.com>
Cc: stable@vger.kernel.org, linux-kernel@vger.kernel.org,
	bpf@vger.kernel.org, netdev@vger.kernel.org, kpsingh@kernel.org,
	john.fastabend@gmail.com, yhs@fb.com, songliubraving@fb.com,
	kafai@fb.com, andrii@kernel.org, daniel@iogearbox.net,
	ast@kernel.org, nickel@altlinux.org, oficerovas@altlinux.org,
	dutyrok@altlinux.org
Subject: Re: [PATCH 5.10.y 0/1] bpf: fix warning ftrace_verify_code
Date: Mon, 29 Jan 2024 21:33:59 +0300	[thread overview]
Message-ID: <87f74eab-ae51-08a4-5b7e-261f437146f4@basealt.ru> (raw)
In-Reply-To: <2024012954-disfigure-barbell-21b9@gregkh>

29.01.2024 19:20, Greg KH wrote:
> On Mon, Jan 29, 2024 at 12:17:45PM +0300, kovalev@altlinux.org wrote:
>> Syzkaller hit 'WARNING in ftrace_verify_code' bug.
>>
>> This bug is not a vulnerability and is reproduced only when running
>> with root privileges on stable 5.10 kernel.
> What about 5.15.y?  We can't take a patch for older kernels and not for
> newer ones, right?

Indeed, this patch was not backported at 5.15.

I fixed it, successfully tested it on the 5.15.148 kernel and sent the 
patch [1]

However, at the time of the kernel build, I noticed a compiler warning 
about an unused "*tmp" variable,

that I fixed in the patch for 5.15, but remained in this patch 5.10:

...

+	void *new, *tmp;
...
need to fix on
...
+	void *new;
...

Therefore, I resend the patch with a fix (deleted the unused tmp 
pointer). [2]

[1] 
https://lore.kernel.org/bpf/20240129180108.284057-1-kovalev@altlinux.org/T/#u

[2] 
https://lore.kernel.org/bpf/20240129183120.284801-1-kovalev@altlinux.org/T/#u

-- 

Regards,
Vasiliy Kovalev


      reply	other threads:[~2024-01-29 18:34 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-01-29  9:17 [PATCH 5.10.y 0/1] bpf: fix warning ftrace_verify_code kovalev
2024-01-29  9:17 ` [PATCH 5.10.y 1/1] bpf: Convert BPF_DISPATCHER to use static_call() (not ftrace) kovalev
2024-01-29 16:20 ` [PATCH 5.10.y 0/1] bpf: fix warning ftrace_verify_code Greg KH
2024-01-29 18:33   ` kovalev [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87f74eab-ae51-08a4-5b7e-261f437146f4@basealt.ru \
    --to=kovalev@altlinux.org \
    --cc=andrii@kernel.org \
    --cc=ast@kernel.org \
    --cc=bpf@vger.kernel.org \
    --cc=daniel@iogearbox.net \
    --cc=dutyrok@altlinux.org \
    --cc=greg@kroah.com \
    --cc=john.fastabend@gmail.com \
    --cc=kafai@fb.com \
    --cc=kpsingh@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=nickel@altlinux.org \
    --cc=oficerovas@altlinux.org \
    --cc=songliubraving@fb.com \
    --cc=stable@vger.kernel.org \
    --cc=yhs@fb.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox