From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-io1-f45.google.com (mail-io1-f45.google.com [209.85.166.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5E12720E6E3 for ; Fri, 30 May 2025 13:30:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.166.45 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1748611804; cv=none; b=CV415v6VtrCWcvJf/LTE1jdykJYAvxvr4RJdpvuhBUuUVE+hkFoYLQI/kslfL2sZyCGBMYpUn7Y3CmJq65hSBWLttD+yP4312RaEVDVuqGGCEmrYJ6K7yjKacWATXba/1iu2Wwp0xnfLJC5lp1124+oceZkPQO8/klIaDIucNmc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1748611804; c=relaxed/simple; bh=RHx4a42drAGL1oYzsD2n8ggD+ROIGozakRFYkRzgh4E=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=TQWdoxtTiOD14it0gdh0bp+U2E8lwBJiNGEVzOgt9ZdtGMRIFdVjcYt5zSsAJyUjsFgytgco8/ne6HpCAB5qKGVdwjAnNjZrxLcWlzjK4Aqed9wESIxXD6SYcJvMYVTDbHViUsPW40GvWehsrf+KOv31Fv72J/ZIg2PCW66+Hcg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.dk; spf=pass smtp.mailfrom=kernel.dk; dkim=pass (2048-bit key) header.d=kernel-dk.20230601.gappssmtp.com header.i=@kernel-dk.20230601.gappssmtp.com header.b=MecKoN05; arc=none smtp.client-ip=209.85.166.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.dk Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=kernel.dk Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel-dk.20230601.gappssmtp.com header.i=@kernel-dk.20230601.gappssmtp.com header.b="MecKoN05" Received: by mail-io1-f45.google.com with SMTP id ca18e2360f4ac-85d9a87660fso188122239f.1 for ; Fri, 30 May 2025 06:30:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20230601.gappssmtp.com; s=20230601; t=1748611802; x=1749216602; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=CNtJuF2JmmWzRjv3i0f39rZGeHHOJRXIAQa1CV7ykN8=; b=MecKoN059sY2MsViaD7yhhWcvehLzWv1Wh0o+b8ftdl4XP5C61ytvSiMjA/fxmovUH guIuC5j3a8EYSon6ziwcaCrBgCbpl7mKTR+BjGBpUQGvoxKOjHh1htomuIlAKAbZFD0X AowW3+3rK2mshZ+kB6fGChf7W0vkTrCzByUhyKjIdNA6zUuVuj91DxIY4lHllUvmm6d6 w39k/T9SeyGndx26iz8FrtJguGKepqnXL/yUGZFIxC0Rrjcu6MDoIWKkjGkcm2+Wr2/6 HfLdVTBHA4P+ySGk2LEOZYyv/8FMU/V+nODHapnayDHyrWtJhwxI5iSpk3mt48aotUH7 8npg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1748611802; x=1749216602; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=CNtJuF2JmmWzRjv3i0f39rZGeHHOJRXIAQa1CV7ykN8=; b=g5XE6iDe41jZDQWQFMtoJckxdvz1WqHxoS5uyB3LQA1n4Q2KsfjAAkhuBixWQOGtMx gxRTsfucTmm6aTMblOqgyvf32wYfqQ1sI0qQ46Ch9Lx83d+tV72/tDhCIQL2JWKf9mmW 0yzqwAZzwN1YHc99AtuvwiLtnBxtqKEO9SaxVwJKqD0kwBv6AqRelnbqOsdRUk1P/7FS M9rNx83roXM9IkCM1ACFIgx3mHZaOxz6Xiaz9KLBp1md64neCdskicOy1/PEfVfCVrYO bNSuItal0DSO0d/O4b0ZPgJpy5nQg9KMrRfn5csBBkXy7pEfub0NQwgGR+5NEG2MqIGW /DdQ== X-Gm-Message-State: AOJu0YxVgro9AviovKg5czrryn6ODXLUGTAsirgki164nocHEPidzQ98 9cnReaL3nYeYdJrm3erB+yKJouFjw2MYsJJf5UFBuwjz12ejF1E5yzd5arsdyZr6GUs= X-Gm-Gg: ASbGncuSc67yLtveq9F0M5LK9gHjd8kVufdJqQHzH7xH7S8SbYUb8TFon+23YAn3Roz wjJtXTANYQ9Jasbat+XDa2XW48JWbZvs2CP/gKQr9YBLATK1+CD4RWRANwyYhx8x3tuLbAgDGBS 4yOoJscWhG9NE6sTe5cPOk6VxdMIqLqTHzKmLonUEtdQmwX13Nf+Hq3bPTBvSu0/N/ZgHR9voE3 SOa3qwbc3CtYeETTqUgO/TjX9h0N5vHDEnVohd2oeqCT4o6iOWeVNTDEcGLTE9jm3EiI3MP859N mTqYKDXN+t14IfBSXi0PAV8jB5b4bw3fDXGzkrOmN3VyQbA= X-Google-Smtp-Source: AGHT+IFJumMPoBGvBdYNWiZVJWqOLRlFymAzul3TodVeaMGzL/NuKERkNsYlyzHi/ArMMVUm4zRKrQ== X-Received: by 2002:a05:6602:3a10:b0:861:d8ca:3587 with SMTP id ca18e2360f4ac-86d0518e799mr213195139f.4.1748611802450; Fri, 30 May 2025 06:30:02 -0700 (PDT) Received: from [192.168.1.116] ([96.43.243.2]) by smtp.gmail.com with ESMTPSA id ca18e2360f4ac-86cf5fdc62fsm62859139f.37.2025.05.30.06.30.01 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 30 May 2025 06:30:01 -0700 (PDT) Message-ID: <87f8b206-e1a2-4b00-b4cf-e00084fc2a42@kernel.dk> Date: Fri, 30 May 2025 07:30:00 -0600 Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH io_uring-next 0/5] io_uring cmd for tx timestamps To: Pavel Begunkov , io-uring@vger.kernel.org, Vadim Fedorenko Cc: netdev@vger.kernel.org, Eric Dumazet , Kuniyuki Iwashima , Paolo Abeni , Willem de Bruijn , "David S . Miller" , Jakub Kicinski , Richard Cochran References: Content-Language: en-US From: Jens Axboe In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 5/30/25 6:18 AM, Pavel Begunkov wrote: > Vadim Fedorenko suggested to add an alternative API for receiving > tx timestamps through io_uring. The series introduces io_uring socket > cmd for fetching tx timestamps, which is a polled multishot request, > i.e. internally polling the socket for POLLERR and posts timestamps > when they're arrives. For the API description see Patch 5. > > It reuses existing timestamp infra and takes them from the socket's > error queue. For networking people the important parts are Patch 1, > and io_uring_cmd_timestamp() from Patch 5 walking the error queue. > > It should be reasonable to take it through the io_uring tree once > we have consensus, but let me know if there are any concerns. FWIW, this series looks good to me. -- Jens Axboe