Re: [PATCH net-next v5 2/3] bnxt_en: Resize RSS contexts on channel count change

["Björn Töpel" <bjorn@kernel.org>]

Jakub Kicinski <kuba@kernel.org> writes:

> On Tue, 17 Mar 2026 09:33:35 +0100 Björn Töpel wrote:
>> +		if (netif_is_rxfh_configured(dev) &&
>> +		    !ethtool_rxfh_can_resize(bp->rss_indir_tbl,
>> +					old_tbl_size, new_tbl_size,
>> +					dev->ethtool->rss_indir_user_size)) {
>> +			netdev_warn(dev, "RSS table resize not possible\n");
>> +			return -EINVAL;
>> +		}
>
> Now that we know the size of the table that user has set 
> we can skip the netif_is_rxfh_configured(dev) and depend fully on
> ethtool_rxfh_can_resize(... rss_indir_user_size) ?
>
> Otherwise we're not making much use of dev->ethtool->rss_indir_user_size
> (the one for the default context / context 0).
> Regardless of the table size user provided IFF_RXFH_CONFIGURED will be
> set.
>
> Which brings me to my last point - I think you can delete
> IFF_RXFH_CONFIGURED and have netif_is_rxfh_configured(dev)
> operate on ..user_size ? We should probably have a new helper
> for when driver lost control over rings and has to reset indir table
> forgetting user config (bnxt mlx5 clearing IFF_RXFH_CONFIGURED).
> Helper should clear the state and issue a Netlink notification?

All good points -- I'll try that! Thanks!