From: Petr Machata <petrm@nvidia.com>
To: David Yang <mmyangfl@gmail.com>
Cc: <netdev@vger.kernel.org>, "David S. Miller" <davem@davemloft.net>,
"Eric Dumazet" <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>,
"Paolo Abeni" <pabeni@redhat.com>,
Simon Horman <horms@kernel.org>, Shuah Khan <shuah@kernel.org>,
Petr Machata <petrm@nvidia.com>, Amit Cohen <amcohen@nvidia.com>,
Li Shuang <shuali@redhat.com>,
Alessandro Zanni <alessandro.zanni87@gmail.com>,
Hangbin Liu <liuhangbin@gmail.com>,
<linux-kselftest@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH net-next v3] selftests: forwarding: Reorder (ar)ping arguments to obey POSIX getopt
Date: Fri, 19 Sep 2025 15:12:08 +0200 [thread overview]
Message-ID: <87frcimvhg.fsf@nvidia.com> (raw)
In-Reply-To: <20250919053538.1106753-1-mmyangfl@gmail.com>
David Yang <mmyangfl@gmail.com> writes:
> Quoted from musl wiki:
>
> GNU getopt permutes argv to pull options to the front, ahead of
> non-option arguments. musl and the POSIX standard getopt stop
> processing options at the first non-option argument with no
> permutation.
>
> Thus these scripts stop working on musl since non-option arguments for
> tools using getopt() (in this case, (ar)ping) do not always come last.
> Fix it by reordering arguments.
>
> Signed-off-by: David Yang <mmyangfl@gmail.com>
Reviewed-by: Petr Machata <petrm@nvidia.com>
next prev parent reply other threads:[~2025-09-19 13:19 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-19 5:35 [PATCH net-next v3] selftests: forwarding: Reorder (ar)ping arguments to obey POSIX getopt David Yang
2025-09-19 13:12 ` Petr Machata [this message]
2025-09-21 6:41 ` Ido Schimmel
2025-09-22 18:40 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87frcimvhg.fsf@nvidia.com \
--to=petrm@nvidia.com \
--cc=alessandro.zanni87@gmail.com \
--cc=amcohen@nvidia.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=liuhangbin@gmail.com \
--cc=mmyangfl@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=shuah@kernel.org \
--cc=shuali@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).