[PATCH net-next 1/2] dt-bindings: net: rfkill-gpio: enable booting in blocked state

[PATCH net-next 1/2] dt-bindings: net: rfkill-gpio: enable booting in blocked state

[Catalin Popescu]

By default, rfkill state is set to unblocked. Sometimes, we want to boot
in blocked state and let the application unblock the rfkill.

Signed-off-by: Catalin Popescu <catalin.popescu@leica-geosystems.com>
---
 Documentation/devicetree/bindings/net/rfkill-gpio.yaml | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/Documentation/devicetree/bindings/net/rfkill-gpio.yaml b/Documentation/devicetree/bindings/net/rfkill-gpio.yaml
index 9630c8466fac..22f26f1a3856 100644
--- a/Documentation/devicetree/bindings/net/rfkill-gpio.yaml
+++ b/Documentation/devicetree/bindings/net/rfkill-gpio.yaml
@@ -32,6 +32,10 @@ properties:
   shutdown-gpios:
     maxItems: 1
 
+  default-blocked:
+    description: configure rfkill state as blocked at boot
+    type: boolean
+
 required:
   - compatible
   - radio-type
@@ -48,4 +52,5 @@ examples:
         label = "rfkill-pcie-wlan";
         radio-type = "wlan";
         shutdown-gpios = <&gpio2 25 GPIO_ACTIVE_HIGH>;
+        default-blocked;
     };

base-commit: 25cc469d6d344f5772e9fb6a5cf9d82a690afe68
prerequisite-patch-id: 0000000000000000000000000000000000000000
-- 
2.34.1

[PATCH net-next 2/2] net: rfkill: gpio: allow booting in blocked state

[Catalin Popescu]

By default, rfkill state is unblocked and this behavior is not
configurable. Add support for booting in blocked state based on the
presence of a devicetree property.

Signed-off-by: Catalin Popescu <catalin.popescu@leica-geosystems.com>
---
 net/rfkill/rfkill-gpio.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/net/rfkill/rfkill-gpio.c b/net/rfkill/rfkill-gpio.c
index 9fa019e0dcad..41e657e97761 100644
--- a/net/rfkill/rfkill-gpio.c
+++ b/net/rfkill/rfkill-gpio.c
@@ -162,6 +162,9 @@ static int rfkill_gpio_probe(struct platform_device *pdev)
 	if (!rfkill->rfkill_dev)
 		return -ENOMEM;
 
+	if (device_property_present(&pdev->dev, "default-blocked"))
+		rfkill_init_sw_state(rfkill->rfkill_dev, true);
+
 	ret = rfkill_register(rfkill->rfkill_dev);
 	if (ret < 0)
 		goto err_destroy;
-- 
2.34.1

Re: [PATCH net-next 1/2] dt-bindings: net: rfkill-gpio: enable booting in blocked state

[POPESCU Catalin]

Due to typo in my send-email command, some recipients were truncated.
Adding them here.

BR,
Catalin

On 10/01/2025 09:19, Catalin Popescu wrote:
> By default, rfkill state is set to unblocked. Sometimes, we want to boot
> in blocked state and let the application unblock the rfkill.
>
> Signed-off-by: Catalin Popescu <catalin.popescu@leica-geosystems.com>
> ---
>   Documentation/devicetree/bindings/net/rfkill-gpio.yaml | 5 +++++
>   1 file changed, 5 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/net/rfkill-gpio.yaml b/Documentation/devicetree/bindings/net/rfkill-gpio.yaml
> index 9630c8466fac..22f26f1a3856 100644
> --- a/Documentation/devicetree/bindings/net/rfkill-gpio.yaml
> +++ b/Documentation/devicetree/bindings/net/rfkill-gpio.yaml
> @@ -32,6 +32,10 @@ properties:
>     shutdown-gpios:
>       maxItems: 1
>   
> +  default-blocked:
> +    description: configure rfkill state as blocked at boot
> +    type: boolean
> +
>   required:
>     - compatible
>     - radio-type
> @@ -48,4 +52,5 @@ examples:
>           label = "rfkill-pcie-wlan";
>           radio-type = "wlan";
>           shutdown-gpios = <&gpio2 25 GPIO_ACTIVE_HIGH>;
> +        default-blocked;
>       };
>
> base-commit: 25cc469d6d344f5772e9fb6a5cf9d82a690afe68
> prerequisite-patch-id: 0000000000000000000000000000000000000000

Re: [PATCH net-next 2/2] net: rfkill: gpio: allow booting in blocked state

[POPESCU Catalin]

Due to typo in my send-email command, some recipients were truncated.
Adding them here.

BR,
Catalin

On 10/01/2025 09:19, Catalin Popescu wrote:
> By default, rfkill state is unblocked and this behavior is not
> configurable. Add support for booting in blocked state based on the
> presence of a devicetree property.
>
> Signed-off-by: Catalin Popescu <catalin.popescu@leica-geosystems.com>
> ---
>   net/rfkill/rfkill-gpio.c | 3 +++
>   1 file changed, 3 insertions(+)
>
> diff --git a/net/rfkill/rfkill-gpio.c b/net/rfkill/rfkill-gpio.c
> index 9fa019e0dcad..41e657e97761 100644
> --- a/net/rfkill/rfkill-gpio.c
> +++ b/net/rfkill/rfkill-gpio.c
> @@ -162,6 +162,9 @@ static int rfkill_gpio_probe(struct platform_device *pdev)
>   	if (!rfkill->rfkill_dev)
>   		return -ENOMEM;
>   
> +	if (device_property_present(&pdev->dev, "default-blocked"))
> +		rfkill_init_sw_state(rfkill->rfkill_dev, true);
> +
>   	ret = rfkill_register(rfkill->rfkill_dev);
>   	if (ret < 0)
>   		goto err_destroy;

Re: [PATCH net-next 1/2] dt-bindings: net: rfkill-gpio: enable booting in blocked state

[Kalle Valo]

Catalin Popescu <catalin.popescu@leica-geosystems.com> writes:

> By default, rfkill state is set to unblocked. Sometimes, we want to boot
> in blocked state and let the application unblock the rfkill.
>
> Signed-off-by: Catalin Popescu <catalin.popescu@leica-geosystems.com>

Don't rfkill patches go via wireless-next, not net-next?

-- 
https://patchwork.kernel.org/project/linux-wireless/list/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches

Re: [PATCH net-next 1/2] dt-bindings: net: rfkill-gpio: enable booting in blocked state

[Conor Dooley]

[-- Attachment #1: Type: text/plain, Size: 1344 bytes --]

On Fri, Jan 10, 2025 at 09:19:01AM +0100, Catalin Popescu wrote:
> By default, rfkill state is set to unblocked. Sometimes, we want to boot
> in blocked state and let the application unblock the rfkill.
> 
> Signed-off-by: Catalin Popescu <catalin.popescu@leica-geosystems.com>
> ---
>  Documentation/devicetree/bindings/net/rfkill-gpio.yaml | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/net/rfkill-gpio.yaml b/Documentation/devicetree/bindings/net/rfkill-gpio.yaml
> index 9630c8466fac..22f26f1a3856 100644
> --- a/Documentation/devicetree/bindings/net/rfkill-gpio.yaml
> +++ b/Documentation/devicetree/bindings/net/rfkill-gpio.yaml
> @@ -32,6 +32,10 @@ properties:
>    shutdown-gpios:
>      maxItems: 1
>  
> +  default-blocked:
> +    description: configure rfkill state as blocked at boot
> +    type: boolean

type here should be flag, not boolean.

> +
>  required:
>    - compatible
>    - radio-type
> @@ -48,4 +52,5 @@ examples:
>          label = "rfkill-pcie-wlan";
>          radio-type = "wlan";
>          shutdown-gpios = <&gpio2 25 GPIO_ACTIVE_HIGH>;
> +        default-blocked;
>      };
> 
> base-commit: 25cc469d6d344f5772e9fb6a5cf9d82a690afe68
> prerequisite-patch-id: 0000000000000000000000000000000000000000
> -- 
> 2.34.1
> 
> 

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]