From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail.toke.dk (mail.toke.dk [45.145.95.4]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 93A8B21B192 for ; Thu, 9 Jan 2025 16:35:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=45.145.95.4 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736440519; cv=none; b=mV/cxvtCn6IoGHqNDxb1B7TiWSqZeV9DOUKyhIo0vSoYVdoGhTmLifERg/SOWtpeZHlHOfVpNOMcLZgqRylilRK6st3jn28xbYx0K/YPNIdPjMhMoHlxsV1OgBlDMEQyrml73eEBISMqPg1XC3cUyP0bWERmLIf+Sr+IK+4c62Q= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736440519; c=relaxed/simple; bh=ANbjk8gqhN0il2QO5ixDt4BuDf3BmOKAImjLOA2m5+0=; h=From:To:Cc:Subject:In-Reply-To:References:Date:Message-ID: MIME-Version:Content-Type; b=Zi1FbP4Od9b2CVQwvx+EhMKkx4UGYZDiRM1SV//8q0D3ZhwMikqPjDvvgHlYU3yEPbvh/jklb6JvXXb5HMdr/GHSYM0xLABpda3zGWxsGT8KR0fDxBYPm/4rF0WJWbDXng73uhJiZk+bvZCvllAuQIzh+hhCpPwnv1jx3roLhNM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=toke.dk; spf=pass smtp.mailfrom=toke.dk; dkim=pass (2048-bit key) header.d=toke.dk header.i=@toke.dk header.b=w1CovmHm; arc=none smtp.client-ip=45.145.95.4 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=toke.dk Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=toke.dk Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=toke.dk header.i=@toke.dk header.b="w1CovmHm" From: Toke =?utf-8?Q?H=C3=B8iland-J=C3=B8rgensen?= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=toke.dk; s=20161023; t=1736440514; bh=ANbjk8gqhN0il2QO5ixDt4BuDf3BmOKAImjLOA2m5+0=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=w1CovmHm+9bvL/zZ07yGdFcwZ1dyVGwl3B+98WXgP83QWcN3SEE49S8bOurAIKqRR 9B7U69aDFWjVFFnvQPWrgKsT3SDVpJupIFrIqipzixAdTvg0dDpPgBeI340aKJaMKc cOu0VSt0A8TID14Gp+iUwr8rOVgKIt9pPNlXF/mYVPGXNyeZGStJz8YNxhSmuE7wZd md2R3qJDq9cXB+UmaihGe+ApZpiM5CYk9GIrwoNfJKGAfB+sBk2khEjhUSMIn23bnK VeptjQMywy4XRTGPp/J4GNPWsdUWYeYSsJBP/nzPPTGCZiM/gn1QSVPvj1UfboChdN jfOIxInzjanbg== To: Jakub Kicinski Cc: Paolo Abeni , Jamal Hadi Salim , Cong Wang , Jiri Pirko , syzbot+f63600d288bfb7057424@syzkaller.appspotmail.com, "David S. Miller" , Eric Dumazet , Simon Horman , cake@lists.bufferbloat.net, netdev@vger.kernel.org Subject: Re: [PATCH net v2] sched: sch_cake: add bounds checks to host bulk flow fairness counts In-Reply-To: <20250109081811.01b7bad1@kernel.org> References: <20250107120105.70685-1-toke@redhat.com> <87plkwi27e.fsf@toke.dk> <11915c70-ec5e-4d94-b890-f07f41094e2c@redhat.com> <87ikqohswh.fsf@toke.dk> <20250109081811.01b7bad1@kernel.org> Date: Thu, 09 Jan 2025 17:35:14 +0100 X-Clacks-Overhead: GNU Terry Pratchett Message-ID: <87frlshrnh.fsf@toke.dk> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Jakub Kicinski writes: > On Thu, 09 Jan 2025 17:08:14 +0100 Toke H=C3=B8iland-J=C3=B8rgensen wrote: >> >> I guess I should have mentioned in the commit message that this was >> >> deliberate. Since it seems you'll be editing that anyway (cf the abov= e), >> >> how about adding a paragraph like: >> >>=20 >> >> As part of this change, the flow quantum calculation is consolidated >> >> into a helper function, which means that the dithering applied to the >> >> host load scaling is now applied both in the DRR rotation and when a >> >> sparse flow's quantum is first initiated. The only user-visible effe= ct >> >> of this is that the maximum packet size that can be sent while a flow >> >> stays sparse will now vary with +/- one byte in some cases. This sho= uld >> >> not make a noticeable difference in practice, and thus it's not worth >> >> complicating the code to preserve the old behaviour.=20=20 >> > >> > It's in Jakub's hands now, possibly he could prefer a repost to reduce >> > the maintainer's overhead.=20=20 >>=20 >> Alright, sure, I'll respin :) > > Hold on, I'll do it :) Crossed streams, but thanks! :) -Toke