RE: [PATCH iwl-next v6 4/6] igb: Introduce XSK data structures and helpers

[Kurt Kanzenbach <kurt@linutronix.de>]

[-- Attachment #1: Type: text/plain, Size: 2861 bytes --]

Hi Sriram,

On Mon Aug 19 2024, Sriram Yagnaraman wrote:
>> -----Original Message-----
>> From: Maciej Fijalkowski <maciej.fijalkowski@intel.com>
>> Sent: Monday, 19 August 2024 16:11
>> To: Kurt Kanzenbach <kurt@linutronix.de>
>> Cc: Tony Nguyen <anthony.l.nguyen@intel.com>; Przemek Kitszel
>> <przemyslaw.kitszel@intel.com>; David S. Miller <davem@davemloft.net>;
>> Eric Dumazet <edumazet@google.com>; Jakub Kicinski <kuba@kernel.org>;
>> Paolo Abeni <pabeni@redhat.com>; Alexei Starovoitov <ast@kernel.org>;
>> Daniel Borkmann <daniel@iogearbox.net>; Jesper Dangaard Brouer
>> <hawk@kernel.org>; John Fastabend <john.fastabend@gmail.com>; Richard
>> Cochran <richardcochran@gmail.com>; Sriram Yagnaraman
>> <sriram.yagnaraman@ericsson.com>; Benjamin Steinke
>> <benjamin.steinke@woks-audio.com>; Sebastian Andrzej Siewior
>> <bigeasy@linutronix.de>; intel-wired-lan@lists.osuosl.org;
>> netdev@vger.kernel.org; bpf@vger.kernel.org; Sriram Yagnaraman
>> <sriram.yagnaraman@est.tech>
>> Subject: Re: [PATCH iwl-next v6 4/6] igb: Introduce XSK data structures and
>> helpers
>>
>> On Mon, Aug 19, 2024 at 03:41:20PM +0200, Kurt Kanzenbach wrote:
>> > On Mon Aug 19 2024, Maciej Fijalkowski wrote:
>> > > On Fri, Aug 16, 2024 at 11:24:03AM +0200, Kurt Kanzenbach wrote:
>> > >> From: Sriram Yagnaraman <sriram.yagnaraman@est.tech>
>> > >>
>> > >> Add the following ring flag:
>> > >> - IGB_RING_FLAG_TX_DISABLED (when xsk pool is being setup)
>> > >>
>> > >> Add a xdp_buff array for use with XSK receive batch API, and a
>> > >> pointer to xsk_pool in igb_adapter.
>> > >>
>> > >> Add enable/disable functions for TX and RX rings.
>> > >> Add enable/disable functions for XSK pool.
>> > >> Add xsk wakeup function.
>> > >>
>> > >> None of the above functionality will be active until
>> > >> NETDEV_XDP_ACT_XSK_ZEROCOPY is advertised in netdev-
>> >xdp_features.
>> > >>
>> > >> Signed-off-by: Sriram Yagnaraman <sriram.yagnaraman@est.tech>
>> > >
>> > > Sriram's mail bounces unfortunately, is it possible to grab his
>> > > current address?
>> >
>> > His current email address is in the Cc list. However, i wasn't sure if
>> > it's okay to update the From and SoB of these patches?
>>
>> Okay. Then I believe Sriram should provide a mailmap entry to map his old
>> mail to a new one.
>
> Please feel free to remove my "est.tech" address from From: and
> Signed-of-By:

Ok, I'll replace your est.tech email address with your ericsson one in
all patches. Or do you have a personal address (like gmail), which you
prefer?

What about the copyright in igb_xsk.c? Does it belong to you, or Intel
or to your previous employer?

> I am just glad that my work has not gone to waste. Thank you for that.

You're welcome.

> I will check with my company's *lawyers* to see if I can provide a
> mailmap to my current address :(

Good luck with that :-).

Thanks,
Kurt

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 861 bytes --]