From: Jakub Sitnicki <jakub@cloudflare.com>
To: Willem de Bruijn <willemdebruijn.kernel@gmail.com>
Cc: Willem de Bruijn <willemb@google.com>,
netdev@vger.kernel.org, kernel-team@cloudflare.com
Subject: Re: EIO on send with UDP_SEGMENT
Date: Wed, 08 Nov 2023 18:55:49 +0100 [thread overview]
Message-ID: <87fs1gkthv.fsf@cloudflare.com> (raw)
In-Reply-To: <CAF=yD-+GNV_1HLyBKGeZuVkRGPEMmyQ4+MX9cLvyC1mC9a+dvg@mail.gmail.com>
On Wed, Nov 08, 2023 at 10:10 AM -05, Willem de Bruijn wrote:
> On Wed, Nov 8, 2023 at 6:03 AM Jakub Sitnicki <jakub@cloudflare.com> wrote:
[...]
>> Do you think the restriction in udp_send_skb can be lifted or tweaked?
>
> The argument against has been that segmentation offload offers no
> performance benefit if the stack has to fall back onto software
> checksumming.
Interesting. Thanks for sharing the context. Must admit, it would have
not been my first guess that the software GSO+checksum itself is not
worth it. Despite it happening late on the TX path.
> If this limitation makes userspace code more complex, by having to
> branch between segmentation offload and not depending on device
> features, that would be an argument to drop it. As you point out, it
> is not needed for correctness.
That answers my question. Thanks for feedback.
next prev parent reply other threads:[~2023-11-08 18:08 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-08 10:58 EIO on send with UDP_SEGMENT Jakub Sitnicki
2023-11-08 15:10 ` Willem de Bruijn
2023-11-08 17:55 ` Jakub Sitnicki [this message]
2023-11-08 19:11 ` Willem de Bruijn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87fs1gkthv.fsf@cloudflare.com \
--to=jakub@cloudflare.com \
--cc=kernel-team@cloudflare.com \
--cc=netdev@vger.kernel.org \
--cc=willemb@google.com \
--cc=willemdebruijn.kernel@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).