From: Jakub Sitnicki <jakub@cloudflare.com>
To: Liu Jian <liujian56@huawei.com>
Cc: john.fastabend@gmail.com, ast@kernel.org, daniel@iogearbox.net,
andrii@kernel.org, martin.lau@linux.dev, song@kernel.org,
yonghong.song@linux.dev, kpsingh@kernel.org, sdf@google.com,
haoluo@google.com, jolsa@kernel.org, davem@davemloft.net,
edumazet@google.com, kuba@kernel.org, pabeni@redhat.com,
dsahern@kernel.org, netdev@vger.kernel.org, bpf@vger.kernel.org
Subject: Re: [PATCH bpf-next v7 7/7] selftests/bpf: add tests for verdict skmsg to closed socket
Date: Mon, 30 Oct 2023 10:04:35 +0100 [thread overview]
Message-ID: <87fs1s1nl2.fsf@cloudflare.com> (raw)
In-Reply-To: <20231028100552.2444158-8-liujian56@huawei.com>
On Sat, Oct 28, 2023 at 06:05 PM +08, Liu Jian wrote:
> Add four tests for verdict skmsg to closed socket in sockmap_basic.c.
>
> Signed-off-by: Liu Jian <liujian56@huawei.com>
> ---
> .../selftests/bpf/prog_tests/sockmap_basic.c | 42 +++++++++++++++----
> 1 file changed, 34 insertions(+), 8 deletions(-)
>
> diff --git a/tools/testing/selftests/bpf/prog_tests/sockmap_basic.c b/tools/testing/selftests/bpf/prog_tests/sockmap_basic.c
> index 75107762a86e..4d49129cdd6b 100644
> --- a/tools/testing/selftests/bpf/prog_tests/sockmap_basic.c
> +++ b/tools/testing/selftests/bpf/prog_tests/sockmap_basic.c
[...]
> @@ -651,15 +669,23 @@ void test_sockmap_basic(void)
> if (test__start_subtest("sockmap skb_verdict msg_f_peek"))
> test_sockmap_skb_verdict_peek();
> if (test__start_subtest("sockmap msg_verdict"))
> - test_sockmap_msg_verdict(false, false, false);
> + test_sockmap_msg_verdict(false, false, false, false);
> if (test__start_subtest("sockmap msg_verdict ingress"))
> - test_sockmap_msg_verdict(true, false, false);
> + test_sockmap_msg_verdict(true, false, false, false);
> if (test__start_subtest("sockmap msg_verdict permanent"))
> - test_sockmap_msg_verdict(false, true, false);
> + test_sockmap_msg_verdict(false, true, false, false);
> if (test__start_subtest("sockmap msg_verdict ingress permanent"))
> - test_sockmap_msg_verdict(true, true, false);
> + test_sockmap_msg_verdict(true, true, false, false);
> if (test__start_subtest("sockmap msg_verdict permanent self"))
> - test_sockmap_msg_verdict(false, true, true);
> + test_sockmap_msg_verdict(false, true, true, false);
> if (test__start_subtest("sockmap msg_verdict ingress permanent self"))
> - test_sockmap_msg_verdict(true, true, true);
> + test_sockmap_msg_verdict(true, true, true, false);
> + if (test__start_subtest("sockmap msg_verdict permanent shutdown"))
> + test_sockmap_msg_verdict(false, true, false, true);
> + if (test__start_subtest("sockmap msg_verdict ingress permanent shutdown"))
> + test_sockmap_msg_verdict(true, true, false, true);
> + if (test__start_subtest("sockmap msg_verdict shutdown"))
> + test_sockmap_msg_verdict(false, false, false, true);
> + if (test__start_subtest("sockmap msg_verdict ingress shutdown"))
> + test_sockmap_msg_verdict(true, false, false, true);
> }
I appreciate the split up of test changes into commits. Thanks.
As you see, the args for test_sockmap_msg_verdict became quite cryptic.
I think having dedicated aliases for 'true' would make it more readable:
const bool INGRESS = true;
const bool PERMANENT = true;
const bool TO_SELF = true;
const bool TARGET_SHUTDOWN = true;
Then invocations as:
test_sockmap_msg_verdict(true, false, false, true);
become:
test_sockmap_msg_verdict(INGRESS, !PERMANENT, !TO_SELF, TARGET_SHUTDOWN);
next prev parent reply other threads:[~2023-10-30 9:11 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-28 10:05 [PATCH bpf-next v7 0/7] add BPF_F_PERMANENT flag for sockmap skmsg redirect Liu Jian
2023-10-28 10:05 ` [PATCH bpf-next v7 1/7] bpf, sockmap: add BPF_F_PERMANENT flag for " Liu Jian
2023-10-28 10:05 ` [PATCH bpf-next v7 2/7] selftests/bpf: Add txmsg permanently test for sockmap Liu Jian
2023-10-28 10:05 ` [PATCH bpf-next v7 3/7] selftests/bpf: Add txmsg redir " Liu Jian
2023-10-28 10:05 ` [PATCH bpf-next v7 4/7] selftests/bpf: add skmsg verdict tests Liu Jian
2023-10-28 10:05 ` [PATCH bpf-next v7 5/7] selftests/bpf: add two skmsg verdict tests for BPF_F_PERMANENT flag Liu Jian
2023-10-28 10:05 ` [PATCH bpf-next v7 6/7] selftests/bpf: add tests for verdict skmsg to itself Liu Jian
2023-10-28 10:05 ` [PATCH bpf-next v7 7/7] selftests/bpf: add tests for verdict skmsg to closed socket Liu Jian
2023-10-30 9:04 ` Jakub Sitnicki [this message]
2023-10-30 9:12 ` [PATCH bpf-next v7 0/7] add BPF_F_PERMANENT flag for sockmap skmsg redirect Jakub Sitnicki
2023-11-04 3:27 ` John Fastabend
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87fs1s1nl2.fsf@cloudflare.com \
--to=jakub@cloudflare.com \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=dsahern@kernel.org \
--cc=edumazet@google.com \
--cc=haoluo@google.com \
--cc=john.fastabend@gmail.com \
--cc=jolsa@kernel.org \
--cc=kpsingh@kernel.org \
--cc=kuba@kernel.org \
--cc=liujian56@huawei.com \
--cc=martin.lau@linux.dev \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=sdf@google.com \
--cc=song@kernel.org \
--cc=yonghong.song@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).