netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Henneberg - Systemdesign <lists@henneberg-systemdesign.com>
To: netdev@vger.kernel.org
Subject: TIOCOUTQ implementation for sockets vs. tty
Date: Wed, 10 Mar 2021 19:16:34 +0100	[thread overview]
Message-ID: <87ft12ri0t.fsf@henneberg-systemdesign.com> (raw)

Hi,

I have a question regarding the implementation of ioctl TIOCOUTQ for
various sockets compared to the tty implementation.

For several sockets, e. g. AF_BLUETOOTH it is done like this

af_bluetooth.c:
case TIOCOUTQ:
	if (sk->sk_state == BT_LISTEN)
		return -EINVAL;

	amount = sk->sk_sndbuf - sk_wmem_alloc_get(sk);
	if (amount < 0)
		amount = 0;
	err = put_user(amount, (int __user *)arg);
	break;

so the ioctl returns the available space in the send queue if I
understand the code correctly (this is also what I observed from tests).

The tty does this:

n_tty.c:
case TIOCOUTQ:
	return put_user(tty_chars_in_buffer(tty), (int __user *) arg);

so it returns the used space in the send queue. This is also what I
would expect from the manpage description.

Is this mismatch intentional?

Regards
-Jochen

             reply	other threads:[~2021-03-10 18:17 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-10 18:16 Henneberg - Systemdesign [this message]
2021-03-10 18:29 ` TIOCOUTQ implementation for sockets vs. tty Willy Tarreau
2021-03-10 20:15   ` Henneberg - Systemdesign

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87ft12ri0t.fsf@henneberg-systemdesign.com \
    --to=lists@henneberg-systemdesign.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).