From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4D752C433DF for ; Tue, 18 Aug 2020 14:52:12 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 298A62080C for ; Tue, 18 Aug 2020 14:52:12 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727120AbgHROwK (ORCPT ); Tue, 18 Aug 2020 10:52:10 -0400 Received: from mail-out.m-online.net ([212.18.0.9]:59024 "EHLO mail-out.m-online.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726863AbgHROwI (ORCPT ); Tue, 18 Aug 2020 10:52:08 -0400 Received: from frontend01.mail.m-online.net (unknown [192.168.8.182]) by mail-out.m-online.net (Postfix) with ESMTP id 4BWDQX4nRPz1qrff; Tue, 18 Aug 2020 16:51:58 +0200 (CEST) Received: from localhost (dynscan1.mnet-online.de [192.168.6.70]) by mail.m-online.net (Postfix) with ESMTP id 4BWDQQ06Pkz1qw74; Tue, 18 Aug 2020 16:51:58 +0200 (CEST) X-Virus-Scanned: amavisd-new at mnet-online.de Received: from mail.mnet-online.de ([192.168.8.182]) by localhost (dynscan1.mail.m-online.net [192.168.6.70]) (amavisd-new, port 10024) with ESMTP id LWUO4G1BT4fj; Tue, 18 Aug 2020 16:51:56 +0200 (CEST) X-Auth-Info: DCEnwxByMyNTdxZ9MycUEdurVz87EDooFxhcWPD98Flztj4THCgDTBIV33A3KT1v Received: from igel.home (ppp-46-244-180-122.dynamic.mnet-online.de [46.244.180.122]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.mnet-online.de (Postfix) with ESMTPSA; Tue, 18 Aug 2020 16:51:56 +0200 (CEST) Received: by igel.home (Postfix, from userid 1000) id 532362C28F0; Tue, 18 Aug 2020 16:51:56 +0200 (CEST) From: Andreas Schwab To: YueHaibing Cc: , , , , , , , , , , Subject: Re: [PATCH] net: stmmac: Fix signedness bug in stmmac_probe_config_dt() References: <20200818143952.50752-1-yuehaibing@huawei.com> X-Yow: I'm also against BODY-SURFING!! Date: Tue, 18 Aug 2020 16:51:56 +0200 In-Reply-To: <20200818143952.50752-1-yuehaibing@huawei.com> (yuehaibing@huawei.com's message of "Tue, 18 Aug 2020 22:39:52 +0800") Message-ID: <87ft8katwz.fsf@igel.home> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Aug 18 2020, YueHaibing wrote: > The "plat->phy_interface" variable is an enum and in this context GCC > will treat it as an unsigned int so the error handling is never > triggered. > > Fixes: b9f0b2f634c0 ("net: stmmac: platform: fix probe for ACPI devices") > Signed-off-by: YueHaibing > --- > drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c b/drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c > index f32317fa75c8..b5b558b02e7d 100644 > --- a/drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c > +++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c > @@ -413,7 +413,7 @@ stmmac_probe_config_dt(struct platform_device *pdev, const char **mac) > } > > plat->phy_interface = device_get_phy_mode(&pdev->dev); > - if (plat->phy_interface < 0) > + if ((int)plat->phy_interface < 0) > return ERR_PTR(plat->phy_interface); I don't think the conversion to long when passed to ERR_PTR will produce a negative value either (if long is wider than unsigned int). Andreas. -- Andreas Schwab, schwab@linux-m68k.org GPG Key fingerprint = 7578 EB47 D4E5 4D69 2510 2552 DF73 E780 A9DA AEC1 "And now for something completely different."