From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0FA6FC43381 for ; Mon, 25 Feb 2019 14:17:34 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id C8C37213A2 for ; Mon, 25 Feb 2019 14:17:33 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726732AbfBYORc (ORCPT ); Mon, 25 Feb 2019 09:17:32 -0500 Received: from mail.taht.net ([176.58.107.8]:58074 "EHLO mail.taht.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726099AbfBYORc (ORCPT ); Mon, 25 Feb 2019 09:17:32 -0500 X-Greylist: delayed 351 seconds by postgrey-1.27 at vger.kernel.org; Mon, 25 Feb 2019 09:17:32 EST Received: from dancer.taht.net (unknown [IPv6:2603:3024:1536:86f0:eea8:6bff:fefe:9a2]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.taht.net (Postfix) with ESMTPSA id CF1E7220ED; Mon, 25 Feb 2019 14:11:38 +0000 (UTC) From: Dave Taht To: Jamal Hadi Salim Cc: Leslie Monis , netdev@vger.kernel.org, dave.taht@gmail.com Subject: Re: [PATCH net-next v2 0/7] net: sched: pie: align PIE implementation with RFC 8033 References: <20190225102051.12268-1-lesliemonis@gmail.com> <19575745-ad10-be2d-6259-5fe39fa71264@mojatatu.com> Date: Mon, 25 Feb 2019 06:11:25 -0800 In-Reply-To: <19575745-ad10-be2d-6259-5fe39fa71264@mojatatu.com> (Jamal Hadi Salim's message of "Mon, 25 Feb 2019 08:47:13 -0500") Message-ID: <87ftsc2c1e.fsf@taht.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Jamal Hadi Salim writes: > On 2019-02-25 8:43 a.m., Jamal Hadi Salim wrote: >> On 2019-02-25 5:20 a.m., Leslie Monis wrote: >>> The current implementation of the PIE queuing discipline is >>> according to the >>> IETF draft [http://tools.ietf.org/html/draft-pan-aqm-pie-00] and >>> the paper >>> [PIE: A Lightweight Control Scheme to Address the Bufferbloat Problem]. >>> However, a lot of necessary modifications and enhancements have >>> been proposed >>> in RFC 8033, which have not yet been incorporated in the source >>> code of Linux. >>> This patch series helps in achieving the same. >>> >>> Performance tests carried out using Flent [https://flent.org/] >>> >> >> +Cc the authors of PIE to double check these values. >> Please respond (it is how open source works!) and N/ACK > > Great. Bouncing addresses. > D. Taht - can you look at this? Whose addresses are bouncing? The folk that did pie originally were mostly contractors and long ago moved on to other things. My taht.net address tends to bounce to vger as I long ago mandated starttls on all email transactions which is why I use my gmail account for postings there. I keep hoping that one day vger will support starttls... posting it here as I'm an optimist. I wasn't expecting to be cc'd on this submittal.... Pie seems to be mostly an abandoned CISCO effort outside of docsis-pie, at least at the moment. I've heard not a peep from them in years. (fq_codel seems to have mostly "won" in our world) I did review all these changes when they went by in v1, and aside from the ecn mistake ending up in the final RFC when I wasn't looking[1], approve of these changes to sch_pie to make it compliant with the rfc, finally. [1] We proposed refining pie's ecn handling here: https://github.com/gautamramk/FQ-PIE-for-Linux-Kernel/issues/2 Anyway: Acked-by: Dave Taht