From: Robert Jarzmik <robert.jarzmik@free.fr>
To: "David S. Miller" <davem@davemloft.net>
Cc: netdev@vger.kernel.org, Arnd Bergmann <arnd@arndb.de>
Subject: Re: [linux-next:master 1436/1582] drivers/net/ethernet/smsc/smc91x.c:2378:6: error: implicit declaration of function 'machine_is_assabet'
Date: Wed, 19 Oct 2016 21:58:06 +0200 [thread overview]
Message-ID: <87funs3ycx.fsf@belgarion.home> (raw)
In-Reply-To: <201610200342.Wv4wShnU%fengguang.wu@intel.com> (kbuild test robot's message of "Thu, 20 Oct 2016 03:31:48 +0800")
Hi David,
Here is a little mess I created with my former serie :
> drivers/net/ethernet/smsc/smc91x.c: In function 'smc_drv_probe':
>>> drivers/net/ethernet/smsc/smc91x.c:2378:6: error: implicit declaration of function 'machine_is_assabet' [-Werror=implicit-function-declaration]
> if (machine_is_assabet() && machine_has_neponset())
> ^~~~~~~~~~~~~~~~~~
> cc1: some warnings being treated as errors
>
> vim +/machine_is_assabet +2378 drivers/net/ethernet/smsc/smc91x.c
The mess comes from the patch "net: smc91x: isolate u16 writes alignment
workaround", where I though I had removed all "machine_is_*()" calls, and I
didn't notice the machine_is_assabet() one.
The fix is to re-add the removed include in the wrong chunk in [1].
Now do you want :
- another apart patch to fix the faulty one
- a "fixup!" patch to fixup the commit in your next tree
- or anything else
As I didn't compile assabet, my testers have missed this one. Please tell me
which way suits you to repair this commit.
Cheers.
next parent reply other threads:[~2016-10-19 19:58 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <201610200342.Wv4wShnU%fengguang.wu@intel.com>
2016-10-19 19:58 ` Robert Jarzmik [this message]
2016-10-19 20:12 ` [linux-next:master 1436/1582] drivers/net/ethernet/smsc/smc91x.c:2378:6: error: implicit declaration of function 'machine_is_assabet' David Miller
2016-10-19 20:17 ` Robert Jarzmik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87funs3ycx.fsf@belgarion.home \
--to=robert.jarzmik@free.fr \
--cc=arnd@arndb.de \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox