From: Vitaly Kuznetsov <vkuznets@redhat.com>
To: Dexuan Cui <decui@microsoft.com>
Cc: David Miller <davem@davemloft.net>,
"olaf\@aepfle.de" <olaf@aepfle.de>,
"gregkh\@linuxfoundation.org" <gregkh@linuxfoundation.org>,
"jasowang\@redhat.com" <jasowang@redhat.com>,
"driverdev-devel\@linuxdriverproject.org"
<driverdev-devel@linuxdriverproject.org>,
"linux-kernel\@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"stephen\@networkplumber.org" <stephen@networkplumber.org>,
"netdev\@vger.kernel.org" <netdev@vger.kernel.org>,
"apw\@canonical.com" <apw@canonical.com>,
"pebolle\@tiscali.nl" <pebolle@tiscali.nl>
Subject: Re: [V2 6/7] hvsock: introduce Hyper-V VM Sockets feature
Date: Fri, 17 Jul 2015 17:04:10 +0200 [thread overview]
Message-ID: <87fv4mn7v9.fsf@vitty.brq.redhat.com> (raw)
In-Reply-To: <d1e303ece500475b8e422d55f82fbffd@SIXPR30MB031.064d.mgd.msft.net> (Dexuan Cui's message of "Thu, 16 Jul 2015 11:19:01 +0000")
Dexuan Cui <decui@microsoft.com> writes:
>> From: David Miller
>> Sent: Thursday, July 16, 2015 12:19
>>
>> From: Dexuan Cui
>> Date: Tue, 14 Jul 2015 03:00:48 -0700
>>
>> > + pr_debug("hvsock_sk_destruct: called\n");
>>
>> Debug logging just to state that a function is called is not appropriate,
>> we have very sophisticated tracing facilities in the kernel that can do
>> that transparently, and more.
>>
>> Please remove this.
> OK.
>
>> > + if (hvsk->channel) {
>> > + pr_debug("hvsock_sk_destruct: calling vmbus_close()\n");
>>
>> Likewise, these kinds of debug logs are totally inappropriate.
> OK, I'll remove all the pr_debug() in the patch.
>
I'd suggest we rather use something like net_dbg_ratelimited()
intead. The driver is new so issues are expected. Some debugging may
be useful)
[...]
--
Vitaly
next prev parent reply other threads:[~2015-07-17 15:04 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-14 10:00 [V2 6/7] hvsock: introduce Hyper-V VM Sockets feature Dexuan Cui
2015-07-16 4:19 ` David Miller
2015-07-16 11:19 ` Dexuan Cui
2015-07-17 15:04 ` Vitaly Kuznetsov [this message]
2015-07-20 5:30 ` Dexuan Cui
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87fv4mn7v9.fsf@vitty.brq.redhat.com \
--to=vkuznets@redhat.com \
--cc=apw@canonical.com \
--cc=davem@davemloft.net \
--cc=decui@microsoft.com \
--cc=driverdev-devel@linuxdriverproject.org \
--cc=gregkh@linuxfoundation.org \
--cc=jasowang@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=olaf@aepfle.de \
--cc=pebolle@tiscali.nl \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).