From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kalle Valo Subject: Re: [PATCH] ath9k_htc: add adaptive usb flow control to repair soft lockup with monitor mode Date: Tue, 03 Feb 2015 13:52:29 +0200 Message-ID: <87fvanxldu.fsf@kamboji.qca.qualcomm.com> References: <1422957585-19736-1-git-send-email-yuweizheng@139.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: linux-kernel@vger.kernel.org, ath9k-devel@lists.ath9k.org, linux-wireless@vger.kernel.org, ath9k-devel@qca.qualcomm.com, netdev@vger.kernel.org, Yuwei Zheng To: yuweizheng@139.com Return-path: In-Reply-To: <1422957585-19736-1-git-send-email-yuweizheng@139.com> (yuweizheng@139.com's message of "Tue, 3 Feb 2015 17:59:45 +0800") Sender: linux-kernel-owner@vger.kernel.org List-Id: netdev.vger.kernel.org yuweizheng@139.com writes: > From: Yuwei Zheng > > In the environment with heavy wifi traffic, set the ar9271 into monitor mode, will > trigger a deadloop panic. > > The ath9k_hif_usb_rx_cb function excute on the interrupt context, and ath9k_rx_tasklet excute > on the soft irq context. In other words, the ath9k_hif_usb_rx_cb have more chance to excute than > ath9k_rx_tasklet. So in the worst condition, the rx.rxbuf receive list is always full, > and the do {}while(true) loop will not be break. The kernel get a soft lockup panic. The word wrapping is still wrong, please limit the width to 72 chars or so. But no need to wrap log snippets, they can exceed the limit. > Signed-off-by: Yuwei Zheng > Signed-off-by: Yuwei Zheng Why two of these? Please use just one Signed-off-by line. Unless these are two different persons with the same name :) -- Kalle Valo