[PATCH] 2.4.x USAGI mipv6_ha_ipsec

[PATCH] 2.4.x USAGI mipv6_ha_ipsec

[Daniel 'NebuchadnezzaR' Dehennin]

Hello,

My 2.4.21 with USAGI 20030801 don't build
/net/ipv6/mobile_ip6/mipv6_ha_ipsec.c :
mipv6_ha_ipsec.c: In function `mipv6_change_sa_index':
mipv6_ha_ipsec.c:118: warning: implicit declaration of function `in6_ntop'
mipv6_ha_ipsec.c:118: warning: format argument is not a pointer (arg 4)
mipv6_ha_ipsec.c:119: warning: format argument is not a pointer (arg 4)
mipv6_ha_ipsec.c:126: warning: format argument is not a pointer (arg 4)
mipv6_ha_ipsec.c:127: warning: format argument is not a pointer (arg 4)
[...]

I search for the definition of in6_ntop, it in include/linux/inet.h
so I make that patch.

Thanks.

--- linux-2.4.21/net/ipv6/mobile_ip6/mipv6_ha_ipsec.c.orig	2003-08-01 19:37:22.000000000 +0200
+++ linux-2.4.21/net/ipv6/mobile_ip6/mipv6_ha_ipsec.c	2003-08-01 19:03:42.000000000 +0200
@@ -62,6 +62,7 @@
 #include <linux/init.h>
 #include <linux/types.h>
 #include <linux/socket.h>
+#include <linux/inet.h>
 #include <linux/in6.h>
 #include <linux/pfkeyv2.h>
 #include <net/spd.h>


-- 
Daniel 'NebuchadnezzaR' Dehennin

[PATCH 2] 2.4.x USAGI unused variables in mipv6_ha_ipsec.c

[Daniel 'NebuchadnezzaR' Dehennin]

Hello again ;-),

A patch to remove unused variables :
mipv6_ha_ipsec.c: In function `__mipv6_mn_change_tunnel_ipsec_by_proto':
mipv6_ha_ipsec.c:216: warning: unused variable `ret'
mipv6_ha_ipsec.c: In function `__mipv6_ha_change_tunnel_ipsec_by_proto':
mipv6_ha_ipsec.c:338: warning: unused variable `ret'

See you.

--- linux-2.4.21/net/ipv6/mobile_ip6/mipv6_ha_ipsec.c.orig	2003-08-01 20:06:15.000000000 +0200
+++ linux-2.4.21/net/ipv6/mobile_ip6/mipv6_ha_ipsec.c	2003-08-01 20:06:42.000000000 +0200
@@ -213,7 +213,6 @@ int __mipv6_mn_change_tunnel_ipsec_by_pr
 	struct in6_addr dst;
 	struct in6_addr src;
 	struct in6_addr *coa = &entry->coa;
-	int ret = 0;
 
 	/*
 	 * Phase 1: Change the following SA/SPD
@@ -335,7 +334,6 @@ int __mipv6_ha_change_tunnel_ipsec_by_pr
 	struct in6_addr dst;
 	struct in6_addr src;
 	struct in6_addr *coa = &entry->coa;
-	int ret = 0;
 
 	/*
 	 * Phase 1: Change the following SA/SPD

-- 
Daniel 'NebuchadnezzaR' Dehennin

Re: [PATCH] 2.4.x USAGI mipv6_ha_ipsec

[Noriaki Takamiya]

Hi,

>> Fri, 01 Aug 2003 19:53:23 +0200
>> [Subject: [PATCH] 2.4.x USAGI mipv6_ha_ipsec]
>> "Daniel 'NebuchadnezzaR' Dehennin" <nebuchadnezzar@nerim.net> wrote...

nebuchadnezzar> I search for the definition of in6_ntop, it in include/linux/inet.h
nebuchadnezzar> so I make that patch.

>> Fri, 01 Aug 2003 20:09:25 +0200
>> [Subject: [PATCH 2] 2.4.x USAGI unused variables in mipv6_ha_ipsec.c]
>> "Daniel 'NebuchadnezzaR' Dehennin" <nebuchadnezzar@nerim.net> wrote...

nebuchadnezzar> Hello again ;-),
nebuchadnezzar> 
nebuchadnezzar> A patch to remove unused variables :

  Applied both fixes. Thakns.

--
Noriaki Takamiya