From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6610E32C942 for ; Mon, 3 Nov 2025 14:50:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1762181418; cv=none; b=SghOGRrI622W81Gf27uUTcC+MCMi0yKFJBmoJxdEzw92sZ47xUT3T4BhBrnECluInZCcW3EQpQTMZtkho2T9ACbVb4hO/CGlfCqGSLK3pN4giGB5gml4uHmNs2OPLo5D79iubZqmd+sWn5mveEiGCDwC4ImHBfaXWMUtdMnVHQg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1762181418; c=relaxed/simple; bh=awDPBHUqeWdiCTx68GRboOT/DtuaFpnsr65AopF29ug=; h=From:To:Cc:Subject:In-Reply-To:References:Date:Message-ID: MIME-Version:Content-Type; b=nhpmA/h5BtWTbPvXUzCjrKj+AhjBD9ziBqbS/5AytRRjCnhCHCbyxdEakZlhZKfThNwc5YpYiEtuMf4ohvIfFLv4hzyHP3DYyP0oo/f+avMfrI8hWyiykykW3u+ek78uH5IA/pfe5fzNqT5ONztjpaYlf1KkeJ1YqkMI9Oq7dF8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=ddPEAzOK; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=RyaWd2qm; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="ddPEAzOK"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="RyaWd2qm" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1762181415; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=+nMoLQg870a5vLIr0xXAcHBID4BH0thIsNlUoCS1bvw=; b=ddPEAzOKGCXocCQcptdFyd20i4zr+hWdawWw1HYsPyLW/9LjT6qwVwBHtymtYxWUw9iTJU fPrMS4QqSkT3dDGQftJKABh5vlKJXcsFNaUUlfuKFXXNl6EDoPey27uviQ9XnuRU5kwSOF GquIUxd2lig4m13J53Dtz3/3BSoqer0= Received: from mail-ed1-f69.google.com (mail-ed1-f69.google.com [209.85.208.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-219-hjJ-QDEXMo65bp4y2fIVwQ-1; Mon, 03 Nov 2025 09:50:13 -0500 X-MC-Unique: hjJ-QDEXMo65bp4y2fIVwQ-1 X-Mimecast-MFC-AGG-ID: hjJ-QDEXMo65bp4y2fIVwQ_1762181412 Received: by mail-ed1-f69.google.com with SMTP id 4fb4d7f45d1cf-640b8087663so2692886a12.3 for ; Mon, 03 Nov 2025 06:50:13 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1762181412; x=1762786212; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:from:to:cc:subject:date:message-id :reply-to; bh=+nMoLQg870a5vLIr0xXAcHBID4BH0thIsNlUoCS1bvw=; b=RyaWd2qmMgLNxTEMP+ty7Hf7+cPTiZbtYEZrbVlO5TCfB5ecEWMIgphfpThCwMzPk2 CKGLsyeGz4mjIXYVawPbk3kfmpTVVOhno2tLd/+QP9NgFDiOEghCaFaSKI3VREeM7sBf 0U91Mt2+hDO+jKrv4fXEcY+y0zVHcoGCa10Mo+KzHQ/QvfmUfY6neKC8sx/Be6gE99aV JjhLNkdAFVzQBA950JK0ynx+/Ypg1zCaZLz9hwFEAyWFJ4Ki+5oSlrNv/U84tOWOCAAd aTWnn/a9ozB6Z4Ktyze8X/yrGYEtRyBxki0m2v1suGKa6BZMw56FewcGoiqvVOfdOS6H YTjw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1762181412; x=1762786212; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=+nMoLQg870a5vLIr0xXAcHBID4BH0thIsNlUoCS1bvw=; b=QzswsRz6tdBl+bFT7nlWpPVbuf8EFs+lSS/vRjIRWTIOBjYh41E6WiCVN8SabPLsch UVAOJMoYqCiVIcPT6Zj2PBB/t6135khEJ5mqAYebmrS0jGmfmN1q6MqFIQI0SegDdN/C 02RukFa5FPERESd9CpK4pfrujyc7BSyqMGEHMed1sp/Of2gFLWohLIt2f7UuPzhSYoLr fbuc1QH6ewUF84FVAkj9uAzHW30OpUXXl8jUEn7/syoiMMwPB6GMUjXHHoEYSv6BrPgi 6uapcGqSIJDj+n3kx6I8xcyYyEBkdzx6b5IbGNexMc3Z+vsNiCm8+IySx8iTFDrXRkXa 5ZPA== X-Forwarded-Encrypted: i=1; AJvYcCW9mtUSxAmRy+KawMgSc24h8vr8BXQsfR22uTMJBDvd5hWru04oM21H6kAPQg3BRzD3ZXikpTQ=@vger.kernel.org X-Gm-Message-State: AOJu0YzLvQA3bviK+2xb24e1Pj39+skk0dR7uMlJBX+kq42BAHuvTVg/ 6bU0Ym8QE0N6sMEgEdYBY6QTo4wZ1Qi6uhWr8c6SwWI93Iruz6amsBR1yo2zAksMvE8cU6yuDcB 3Rv5qxGBpSKBDZhWUVZxaoq7ynsar2BmvxzXzCusmMhqxcYKtKU22Ewqj1w== X-Gm-Gg: ASbGncu16zqUH74BKeH41aD0TMlmObEYGGe5b4Ak6LE5slQfs+qyX/JUAZE9NslRvhC kDYTZIlO3NjBGUKfdtl1Cz7wssRXogXF1KPEAL22l0nsGh4pvpQ/PftvWZMoKUDgu2OE9QagkIF XHg8ylM89wDEF9k9bccFHoGFgFxMwM5S3uJguCJhDRhz7UtlQelSmyQ77MdRz6cXD6nEkFIUUzw O1+XeRIX05BoSEdgtQ9Z459iijiHXALYiDvwHTpEgYTwLN7du7T/W1tzPWlS3lRnObQpiqBY5Vs edIlX02Cii61ZBjQSGDVECbgz6MAuVUMmn6LTmeTxs2tnjB3r20HUxoEKc8/oEJV+Q6pefj3YY2 EkQc6HV+CS5tu76RqjlToiRo= X-Received: by 2002:a05:6402:34ca:b0:640:b497:bf71 with SMTP id 4fb4d7f45d1cf-640b497c2admr4755517a12.8.1762181411915; Mon, 03 Nov 2025 06:50:11 -0800 (PST) X-Google-Smtp-Source: AGHT+IHNHHGCfan3xN8hz0VQLwH+oMIT11J2vhXom0DZu1MBhk6Duw5v6C2YzkNLZvnmt+vEeRS3LQ== X-Received: by 2002:a05:6402:34ca:b0:640:b497:bf71 with SMTP id 4fb4d7f45d1cf-640b497c2admr4755480a12.8.1762181411457; Mon, 03 Nov 2025 06:50:11 -0800 (PST) Received: from alrua-x1.borgediget.toke.dk ([45.145.92.2]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-640b977e6acsm4056741a12.25.2025.11.03.06.50.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 03 Nov 2025 06:50:10 -0800 (PST) Received: by alrua-x1.borgediget.toke.dk (Postfix, from userid 1000) id B7D07328476; Mon, 03 Nov 2025 15:50:09 +0100 (CET) From: Toke =?utf-8?Q?H=C3=B8iland-J=C3=B8rgensen?= To: Byungchul Park Cc: linux-mm@kvack.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, kernel_team@skhynix.com, harry.yoo@oracle.com, ast@kernel.org, daniel@iogearbox.net, davem@davemloft.net, kuba@kernel.org, hawk@kernel.org, john.fastabend@gmail.com, sdf@fomichev.me, saeedm@nvidia.com, leon@kernel.org, tariqt@nvidia.com, mbloch@nvidia.com, andrew+netdev@lunn.ch, edumazet@google.com, pabeni@redhat.com, akpm@linux-foundation.org, david@redhat.com, lorenzo.stoakes@oracle.com, Liam.Howlett@oracle.com, vbabka@suse.cz, rppt@kernel.org, surenb@google.com, mhocko@suse.com, horms@kernel.org, jackmanb@google.com, hannes@cmpxchg.org, ziy@nvidia.com, ilias.apalodimas@linaro.org, willy@infradead.org, brauner@kernel.org, kas@kernel.org, yuzhao@google.com, usamaarif642@gmail.com, baolin.wang@linux.alibaba.com, almasrymina@google.com, asml.silence@gmail.com, bpf@vger.kernel.org, linux-rdma@vger.kernel.org, sfr@canb.auug.org.au, dw@davidwei.uk, ap420073@gmail.com, dtatulea@nvidia.com Subject: Re: [RFC mm v5 2/2] mm: introduce a new page type for page pool in page type In-Reply-To: <20251103123942.GA64460@system.software.com> References: <20251103075108.26437-1-byungchul@sk.com> <20251103075108.26437-3-byungchul@sk.com> <87jz07pajq.fsf@toke.dk> <20251103123942.GA64460@system.software.com> X-Clacks-Overhead: GNU Terry Pratchett Date: Mon, 03 Nov 2025 15:50:09 +0100 Message-ID: <87h5vbp3vi.fsf@toke.dk> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Byungchul Park writes: > On Mon, Nov 03, 2025 at 01:26:01PM +0100, Toke H=C3=B8iland-J=C3=B8rgense= n wrote: >> Byungchul Park writes: >>=20 >> > Currently, the condition 'page->pp_magic =3D=3D PP_SIGNATURE' is used = to >> > determine if a page belongs to a page pool. However, with the planned >> > removal of ->pp_magic, we should instead leverage the page_type in >> > struct page, such as PGTY_netpp, for this purpose. >> > >> > Introduce and use the page type APIs e.g. PageNetpp(), __SetPageNetpp(= ), >> > and __ClearPageNetpp() instead, and remove the existing APIs accessing >> > ->pp_magic e.g. page_pool_page_is_pp(), netmem_or_pp_magic(), and >> > netmem_clear_pp_magic(). >> > >> > This work was inspired by the following link: >> > >> > [1] https://lore.kernel.org/all/582f41c0-2742-4400-9c81-0d46bf4e8314@g= mail.com/ >> > >> > While at it, move the sanity check for page pool to on free. >> > >> > Suggested-by: David Hildenbrand >> > Co-developed-by: Pavel Begunkov >> > Signed-off-by: Pavel Begunkov >> > Signed-off-by: Byungchul Park >> > Acked-by: David Hildenbrand >> > Acked-by: Zi Yan >> > Acked-by: Mina Almasry >>=20 >> Acked-by: Toke H=C3=B8iland-J=C3=B8rgensen >>=20 >> IIUC, this will allow us to move the PP-specific fields out of struct >> page entirely at some point, right? What are the steps needed to get to >> that point after this? > > Yes, it'd be almost done once this set gets merged :-) > > Will check if I can safely remove pp fields from struct page, and do > it! Sounds good, thanks! -Toke