From: Jonathan Corbet <corbet@lwn.net>
To: Reyders Morales <reyders1@gmail.com>, linux-doc@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, valla.francesco@gmail.com,
Reyders Morales <reyders1@gmail.com>,
netdev@vger.kernel.org
Subject: Re: [PATCH] Documentation/networking: Fix basic node example document ISO 15765-2
Date: Tue, 21 Jan 2025 17:06:08 -0700 [thread overview]
Message-ID: <87h65remq7.fsf@trenco.lwn.net> (raw)
In-Reply-To: <20250121225241.128810-1-reyders1@gmail.com>
[CC += netdev - they may want a resend after the merge window though]
Reyders Morales <reyders1@gmail.com> writes:
> In the current struct sockaddr_can tp is member of can_addr.
> tp is not member of struct sockaddr_can.
>
> Signed-off-by: Reyders Morales <reyders1@gmail.com>
> ---
> Documentation/networking/iso15765-2.rst | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/Documentation/networking/iso15765-2.rst b/Documentation/networking/iso15765-2.rst
> index 0e9d96074178..37ebb2c417cb 100644
> --- a/Documentation/networking/iso15765-2.rst
> +++ b/Documentation/networking/iso15765-2.rst
> @@ -369,8 +369,8 @@ to their default.
>
> addr.can_family = AF_CAN;
> addr.can_ifindex = if_nametoindex("can0");
> - addr.tp.tx_id = 0x18DA42F1 | CAN_EFF_FLAG;
> - addr.tp.rx_id = 0x18DAF142 | CAN_EFF_FLAG;
> + addr.can_addr.tp.tx_id = 0x18DA42F1 | CAN_EFF_FLAG;
> + addr.can_addr.tp.rx_id = 0x18DAF142 | CAN_EFF_FLAG;
>
> ret = bind(s, (struct sockaddr *)&addr, sizeof(addr));
> if (ret < 0)
> --
> 2.43.0
next parent reply other threads:[~2025-01-22 0:06 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20250121225241.128810-1-reyders1@gmail.com>
2025-01-22 0:06 ` Jonathan Corbet [this message]
2025-01-22 0:48 ` [PATCH] Documentation/networking: Fix basic node example document ISO 15765-2 Jakub Kicinski
2025-02-03 22:47 Reyders Morales
2025-02-04 7:40 ` Oliver Hartkopp
2025-02-04 13:45 ` Simon Horman
2025-02-06 8:02 ` Marc Kleine-Budde
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87h65remq7.fsf@trenco.lwn.net \
--to=corbet@lwn.net \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=reyders1@gmail.com \
--cc=valla.francesco@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).