From: Michael Ellerman <mpe@ellerman.id.au>
To: Christophe Leroy <christophe.leroy@csgroup.eu>,
Mina Almasry <almasrymina@google.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: Jesper Dangaard Brouer <hawk@kernel.org>,
Ilias Apalodimas <ilias.apalodimas@linaro.org>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Simon Horman <horms@kernel.org>,
Stephen Rothwell <sfr@canb.auug.org.au>,
Linux Next Mailing List <linux-next@vger.kernel.org>,
Arnd Bergmann <arnd@arndb.de>,
"linuxppc-dev@lists.ozlabs.org" <linuxppc-dev@lists.ozlabs.org>,
Matthew Wilcox <willy@infradead.org>
Subject: Re: [PATCH net-next v2] page_pool: fix build on powerpc with GCC 14
Date: Sun, 15 Sep 2024 22:19:58 +1000 [thread overview]
Message-ID: <87h6ahqfbl.fsf@mail.lhotse> (raw)
In-Reply-To: <498e7990-2c81-4779-83e6-1ff072796dbd@csgroup.eu>
Christophe Leroy <christophe.leroy@csgroup.eu> writes:
> Le 14/09/2024 à 04:02, Michael Ellerman a écrit :
...
>>
>> diff --git a/arch/powerpc/include/asm/atomic.h b/arch/powerpc/include/asm/atomic.h
>> index 5bf6a4d49268..0e41c1da82dd 100644
>> --- a/arch/powerpc/include/asm/atomic.h
>> +++ b/arch/powerpc/include/asm/atomic.h
>> @@ -23,6 +23,12 @@
>> #define __atomic_release_fence() \
>> __asm__ __volatile__(PPC_RELEASE_BARRIER "" : : : "memory")
>>
>> +#ifdef CONFIG_CC_IS_CLANG
>> +#define DS_FORM_CONSTRAINT "Z<>"
>> +#else
>> +#define DS_FORM_CONSTRAINT "YZ<>"
>> +#endif
>
> I see we have the same in uaccess.h, added by commit 2d43cc701b96
> ("powerpc/uaccess: Fix build errors seen with GCC 13/14")
Yep.
> Should that go in a common header, maybe ppc_asm.h ?
That would be the obvious place, but unfortunately including ppc_asm.h
in atomic.h breaks the build due to header spaghetti.
For now I've put the defines in asm-compat.h, which is not ideal but
seems to work.
cheers
next prev parent reply other threads:[~2024-09-15 12:20 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-13 21:33 [PATCH net-next v2] page_pool: fix build on powerpc with GCC 14 Mina Almasry
2024-09-13 21:38 ` Mina Almasry
2024-09-13 21:55 ` Matthew Wilcox
2024-09-13 22:20 ` Mina Almasry
2024-09-14 0:17 ` Jakub Kicinski
2024-09-14 0:43 ` Mina Almasry
2024-09-13 21:55 ` Stanislav Fomichev
2024-09-13 21:59 ` Matthew Wilcox
2024-09-13 22:27 ` Stanislav Fomichev
2024-09-13 23:26 ` Mina Almasry
2024-09-13 22:23 ` Mina Almasry
2024-09-14 2:02 ` Michael Ellerman
2024-09-14 3:17 ` Jakub Kicinski
2024-09-14 8:55 ` Christophe Leroy
2024-09-15 12:19 ` Michael Ellerman [this message]
2024-09-15 23:16 ` Stephen Rothwell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87h6ahqfbl.fsf@mail.lhotse \
--to=mpe@ellerman.id.au \
--cc=almasrymina@google.com \
--cc=arnd@arndb.de \
--cc=christophe.leroy@csgroup.eu \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=hawk@kernel.org \
--cc=horms@kernel.org \
--cc=ilias.apalodimas@linaro.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=sfr@canb.auug.org.au \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).