[PATCH] iwlwifi: don't spam logs with NSS>2 messages

[PATCH] iwlwifi: don't spam logs with NSS>2 messages

[Jason A. Donenfeld]

I get a log line like this every 4 seconds when connected to my AP:

[15650.221468] iwlwifi 0000:09:00.0: Got NSS = 4 - trimming to 2

Looking at the code, this seems to be related to a hardware limitation,
and there's nothing to be done. In an effort to keep my dmesg
manageable, downgrade this error to "debug" rather than "info".

Cc: Johannes Berg <johannes.berg@intel.com>
Signed-off-by: Jason A. Donenfeld <Jason@zx2c4.com>
---
 drivers/net/wireless/intel/iwlwifi/mvm/mac80211.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/net/wireless/intel/iwlwifi/mvm/mac80211.c b/drivers/net/wireless/intel/iwlwifi/mvm/mac80211.c
index 5eb28f8ee87e..11536f115198 100644
--- a/drivers/net/wireless/intel/iwlwifi/mvm/mac80211.c
+++ b/drivers/net/wireless/intel/iwlwifi/mvm/mac80211.c
@@ -1833,8 +1833,8 @@ static void iwl_mvm_parse_ppe(struct iwl_mvm *mvm,
 	* If nss < MAX: we can set zeros in other streams
 	*/
 	if (nss > MAX_HE_SUPP_NSS) {
-		IWL_INFO(mvm, "Got NSS = %d - trimming to %d\n", nss,
-			 MAX_HE_SUPP_NSS);
+		IWL_DEBUG_INFO(mvm, "Got NSS = %d - trimming to %d\n", nss,
+			       MAX_HE_SUPP_NSS);
 		nss = MAX_HE_SUPP_NSS;
 	}
 
-- 
2.37.3

Re: [PATCH] iwlwifi: don't spam logs with NSS>2 messages

[Kalle Valo]

"Jason A. Donenfeld" <Jason@zx2c4.com> writes:

> I get a log line like this every 4 seconds when connected to my AP:
>
> [15650.221468] iwlwifi 0000:09:00.0: Got NSS = 4 - trimming to 2
>
> Looking at the code, this seems to be related to a hardware limitation,
> and there's nothing to be done. In an effort to keep my dmesg
> manageable, downgrade this error to "debug" rather than "info".
>
> Cc: Johannes Berg <johannes.berg@intel.com>
> Signed-off-by: Jason A. Donenfeld <Jason@zx2c4.com>

Gregory, can I take this directly to wireless tree for v6.0?

-- 
https://patchwork.kernel.org/project/linux-wireless/list/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches

Re: [PATCH] iwlwifi: don't spam logs with NSS>2 messages

[Johannes Berg]

On Mon, 2022-09-05 at 20:39 +0300, Kalle Valo wrote:
> "Jason A. Donenfeld" <Jason@zx2c4.com> writes:
> 
> > I get a log line like this every 4 seconds when connected to my AP:
> > 
> > [15650.221468] iwlwifi 0000:09:00.0: Got NSS = 4 - trimming to 2
> > 
> > Looking at the code, this seems to be related to a hardware limitation,
> > and there's nothing to be done. In an effort to keep my dmesg
> > manageable, downgrade this error to "debug" rather than "info".
> > 
> > Cc: Johannes Berg <johannes.berg@intel.com>
> > Signed-off-by: Jason A. Donenfeld <Jason@zx2c4.com>
> 
> Gregory, can I take this directly to wireless tree for v6.0?
> 
We have an identical patch in our tree that I wrote a while ago, just
hasn't made it out ... I guess you can :)

johannes

Re: wifi: iwlwifi: don't spam logs with NSS>2 messages

[Kalle Valo]

"Jason A. Donenfeld" <Jason@zx2c4.com> wrote:

> I get a log line like this every 4 seconds when connected to my AP:
> 
> [15650.221468] iwlwifi 0000:09:00.0: Got NSS = 4 - trimming to 2
> 
> Looking at the code, this seems to be related to a hardware limitation,
> and there's nothing to be done. In an effort to keep my dmesg
> manageable, downgrade this error to "debug" rather than "info".
> 
> Cc: Johannes Berg <johannes.berg@intel.com>
> Signed-off-by: Jason A. Donenfeld <Jason@zx2c4.com>

Patch applied to wireless.git, thanks.

4d8421f2dd88 wifi: iwlwifi: don't spam logs with NSS>2 messages

-- 
https://patchwork.kernel.org/project/linux-wireless/patch/20220905172246.105383-1-Jason@zx2c4.com/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches