From: "Toke Høiland-Jørgensen" <toke@redhat.com>
To: Joe Damato <jdamato@fastly.com>,
Jesper Dangaard Brouer <jbrouer@redhat.com>
Cc: netdev@vger.kernel.org, kuba@kernel.org,
ilias.apalodimas@linaro.org, davem@davemloft.net,
hawk@kernel.org, saeed@kernel.org, ttoukan.linux@gmail.com,
brouer@redhat.com
Subject: Re: [net-next v7 4/4] mlx5: add support for page_pool_get_stats
Date: Mon, 28 Feb 2022 10:08:46 +0100 [thread overview]
Message-ID: <87h78jxsrl.fsf@toke.dk> (raw)
In-Reply-To: <CALALjgxS0q+Vbg8rgrqTZ+CSV=9tXOTdxE7S4VGGnvsbicLE3A@mail.gmail.com>
Joe Damato <jdamato@fastly.com> writes:
> On Sun, Feb 27, 2022 at 11:28 PM Jesper Dangaard Brouer
> <jbrouer@redhat.com> wrote:
>>
>>
>>
>> On 25/02/2022 18.41, Joe Damato wrote:
>> > +#ifdef CONFIG_PAGE_POOL_STATS
>> > + { MLX5E_DECLARE_RX_STAT(struct mlx5e_rq_stats, page_pool_fast) },
>> > + { MLX5E_DECLARE_RX_STAT(struct mlx5e_rq_stats, page_pool_slow) },
>> > + { MLX5E_DECLARE_RX_STAT(struct mlx5e_rq_stats, page_pool_slow_high_order) },
>> > + { MLX5E_DECLARE_RX_STAT(struct mlx5e_rq_stats, page_pool_empty) },
>> > + { MLX5E_DECLARE_RX_STAT(struct mlx5e_rq_stats, page_pool_refill) },
>> > + { MLX5E_DECLARE_RX_STAT(struct mlx5e_rq_stats, page_pool_waive) },
>> > + { MLX5E_DECLARE_RX_STAT(struct mlx5e_rq_stats, page_pool_rec_cached) },
>> > + { MLX5E_DECLARE_RX_STAT(struct mlx5e_rq_stats, page_pool_rec_cache_full) },
>> > + { MLX5E_DECLARE_RX_STAT(struct mlx5e_rq_stats, page_pool_rec_ring) },
>> > + { MLX5E_DECLARE_RX_STAT(struct mlx5e_rq_stats, page_pool_rec_ring_full) },
>> > + { MLX5E_DECLARE_RX_STAT(struct mlx5e_rq_stats, page_pool_rec_released_ref) },
>> > +#endif
>>
>> The naming: "page_pool_rec_xxx".
>> What does the "rec" stand for?
>
> rec stands for recycle.
>
> ethtool strings have a limited size (ETH_GSTRING_LEN - 32 bytes) and
> the full word "recycle" didn't fit for some of the stats once the
> queue number is prepended elsewhere in the driver code.
>
>> Users of ethtool -S stats... will they know "rec" is "recycle" ?
>
> I am open to other names or adding documentation to the driver docs to
> explain the meaning.
You could shorten the 'page_pool_' prefix to 'ppool_' or even 'pp_' and
gain some characters that way?
-Toke
next prev parent reply other threads:[~2022-02-28 9:17 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-25 17:41 [net-next v7 0/4] page_pool: Add stats counters Joe Damato
2022-02-25 17:41 ` [net-next v7 1/4] page_pool: Add allocation stats Joe Damato
2022-02-28 7:07 ` Jesper Dangaard Brouer
2022-02-28 7:28 ` Ilias Apalodimas
2022-02-25 17:41 ` [net-next v7 2/4] page_pool: Add recycle stats Joe Damato
2022-02-28 7:20 ` Jesper Dangaard Brouer
2022-02-28 7:28 ` Ilias Apalodimas
2022-02-25 17:41 ` [net-next v7 3/4] page_pool: Add function to batch and return stats Joe Damato
2022-02-28 7:22 ` Jesper Dangaard Brouer
2022-02-28 7:29 ` Ilias Apalodimas
2022-02-25 17:41 ` [net-next v7 4/4] mlx5: add support for page_pool_get_stats Joe Damato
2022-02-28 7:28 ` Jesper Dangaard Brouer
2022-02-28 8:38 ` Joe Damato
2022-02-28 9:08 ` Toke Høiland-Jørgensen [this message]
2022-03-01 0:51 ` Joe Damato
2022-03-01 11:23 ` Toke Høiland-Jørgensen
2022-03-01 17:00 ` Joe Damato
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87h78jxsrl.fsf@toke.dk \
--to=toke@redhat.com \
--cc=brouer@redhat.com \
--cc=davem@davemloft.net \
--cc=hawk@kernel.org \
--cc=ilias.apalodimas@linaro.org \
--cc=jbrouer@redhat.com \
--cc=jdamato@fastly.com \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=saeed@kernel.org \
--cc=ttoukan.linux@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).