netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Kurt Kanzenbach <kurt@kmk-computers.de>
To: Vladimir Oltean <olteanv@gmail.com>
Cc: Andrew Lunn <andrew@lunn.ch>,
	Vivien Didelot <vivien.didelot@gmail.com>,
	Florian Fainelli <f.fainelli@gmail.com>,
	"David S. Miller" <davem@davemloft.net>,
	Jakub Kicinski <kuba@kernel.org>,
	netdev@vger.kernel.org
Subject: Re: [PATCH net-next v2 4/4] net: dsa: hellcreek: Add devlink FDB region
Date: Sat, 20 Mar 2021 12:31:04 +0100	[thread overview]
Message-ID: <87h7l6kqo7.fsf@kmk-computers.de> (raw)
In-Reply-To: <87pn01ga9p.fsf@kmk-computers.de>

[-- Attachment #1: Type: text/plain, Size: 1053 bytes --]

On Sun Mar 14 2021, Kurt Kanzenbach wrote:
> On Sat Mar 13 2021, Vladimir Oltean wrote:
>> On Sat, Mar 13, 2021 at 10:39:39AM +0100, Kurt Kanzenbach wrote:
>>> Allow to dump the FDB table via devlink. This is a useful debugging feature.
>>> 
>>> Signed-off-by: Kurt Kanzenbach <kurt@kmk-computers.de>
>>> Reviewed-by: Andrew Lunn <andrew@lunn.ch>
>>> ---
>>
>> Reviewed-by: Vladimir Oltean <olteanv@gmail.com>
>>
>> By the way, what user space program do you use to dump these? Did you
>> derive something from Andrew's mv88e6xxx_dump too? Maybe we should work
>> on something common?
>
> Actually there is no user space tooling, yet. My original approach to
> debugging was different using debugfs and tracing. I played a bit with
> mv88e6xxx_dump today. Having a common tool would be quite nice.

Thanks for the pointer to mv88e6xxx_dump. Just needed to implement
.devlink_info_get() callback, so that the tool can distinguish between
the Marvell and Hellcreek devices (and implement some hellcreek
specifics).

Thanks,
Kurt

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 865 bytes --]

  reply	other threads:[~2021-03-20 11:31 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-13  9:39 [PATCH net-next v2 0/4] net: dsa: hellcreek: Add support for dumping tables Kurt Kanzenbach
2021-03-13  9:39 ` [PATCH net-next v2 1/4] net: dsa: hellcreek: Add devlink VLAN region Kurt Kanzenbach
2021-03-13 11:38   ` Vladimir Oltean
2021-03-14  1:40   ` Florian Fainelli
2021-03-13  9:39 ` [PATCH net-next v2 2/4] net: dsa: hellcreek: Use boolean value Kurt Kanzenbach
2021-03-13 11:39   ` Vladimir Oltean
2021-03-14  1:39   ` Florian Fainelli
2021-03-13  9:39 ` [PATCH net-next v2 3/4] net: dsa: hellcreek: Move common code to helper Kurt Kanzenbach
2021-03-13 11:44   ` Vladimir Oltean
2021-03-14  1:41   ` Florian Fainelli
2021-03-13  9:39 ` [PATCH net-next v2 4/4] net: dsa: hellcreek: Add devlink FDB region Kurt Kanzenbach
2021-03-13 11:46   ` Vladimir Oltean
2021-03-14 13:00     ` Kurt Kanzenbach
2021-03-20 11:31       ` Kurt Kanzenbach [this message]
2021-03-14  1:41   ` Florian Fainelli
2021-03-13 22:40 ` [PATCH net-next v2 0/4] net: dsa: hellcreek: Add support for dumping tables patchwork-bot+netdevbpf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87h7l6kqo7.fsf@kmk-computers.de \
    --to=kurt@kmk-computers.de \
    --cc=andrew@lunn.ch \
    --cc=davem@davemloft.net \
    --cc=f.fainelli@gmail.com \
    --cc=kuba@kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=olteanv@gmail.com \
    --cc=vivien.didelot@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).