From: Jakub Sitnicki <jakub@cloudflare.com>
To: Daniel Borkmann <daniel@iogearbox.net>,
Santucci Pierpaolo <santucci@epigenesys.com>
Cc: Andrii Nakryiko <andrii.nakryiko@gmail.com>,
Shuah Khan <shuah@kernel.org>,
Alexei Starovoitov <ast@kernel.org>, Martin Lau <kafai@fb.com>,
Song Liu <songliubraving@fb.com>, Yonghong Song <yhs@fb.com>,
Andrii Nakryiko <andrii@kernel.org>,
john fastabend <john.fastabend@gmail.com>,
KP Singh <kpsingh@chromium.org>,
Networking <netdev@vger.kernel.org>, bpf <bpf@vger.kernel.org>,
sdf@google.com
Subject: Re: [PATCH] selftest/bpf: fix IPV6FR handling in flow dissector
Date: Thu, 12 Nov 2020 10:00:06 +0100 [thread overview]
Message-ID: <87h7pvvtk9.fsf@cloudflare.com> (raw)
In-Reply-To: <292adb9d-899a-fcb0-a37f-cd21e848fede@iogearbox.net>
On Thu, Nov 12, 2020 at 12:06 AM CET, Daniel Borkmann wrote:
[...]
>>> I'm not initimately familiar with this test, but looking at the change
>>> I'd consider that Destinations Options and encapsulation headers can
>>> follow the Fragment Header.
>>>
>>> With enough of Dst Opts or levels of encapsulation, transport header
>>> could be pushed to the 2nd fragment. So I'm not sure if the assertion
>>> from the IPv4 dissector that 2nd fragment and following doesn't contain
>>> any parseable header holds.
>
> Hm, staring at rfc8200, it says that the first fragment packet must include
> the upper-layer header (e.g. tcp, udp). The patch here should probably add a
> comment wrt to the rfc.
You're right, it clearly says so. Nevermind my worries about malformed
packets then. Change LGTM:
Reviewed-by: Jakub Sitnicki <jakub@cloudflare.com>
next prev parent reply other threads:[~2020-11-12 9:00 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-10 17:12 [PATCH] selftest/bpf: fix IPV6FR handling in flow dissector Santucci Pierpaolo
2020-11-11 4:48 ` Andrii Nakryiko
2020-11-11 11:17 ` Jakub Sitnicki
2020-11-11 14:12 ` Santucci Pierpaolo
2020-11-11 23:06 ` Daniel Borkmann
2020-11-12 9:00 ` Jakub Sitnicki [this message]
2020-11-13 0:50 ` John Fastabend
2020-11-16 10:30 ` [PATCH v2] " Santucci Pierpaolo
2020-11-16 12:18 ` Jakub Sitnicki
2020-11-16 16:10 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87h7pvvtk9.fsf@cloudflare.com \
--to=jakub@cloudflare.com \
--cc=andrii.nakryiko@gmail.com \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=john.fastabend@gmail.com \
--cc=kafai@fb.com \
--cc=kpsingh@chromium.org \
--cc=netdev@vger.kernel.org \
--cc=santucci@epigenesys.com \
--cc=sdf@google.com \
--cc=shuah@kernel.org \
--cc=songliubraving@fb.com \
--cc=yhs@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).