From: Kalle Valo <kvalo@codeaurora.org>
To: Arend Van Spriel <arend.vanspriel@broadcom.com>
Cc: "Seung-Woo Kim" <sw0312.kim@samsung.com>,
<franky.lin@broadcom.com>, <hante.meuleman@broadcom.com>,
<chi-hsien.lin@cypress.com>, <wright.feng@cypress.com>,
<davem@davemloft.net>, <kuba@kernel.org>,
<linux-wireless@vger.kernel.org>,
<brcm80211-dev-list.pdl@broadcom.com>,
<brcm80211-dev-list@cypress.com>, <smoch@web.de>,
<sandals@crustytoothpaste.net>, <rafal@milecki.pl>,
<digetx@gmail.com>, <double.lo@cypress.com>, <amsr@cypress.com>,
<stanley.hsu@cypress.com>, <saravanan.shanmugham@cypress.com>,
<jean-philippe@linaro.org>, <frank.kao@cypress.com>,
<netdev@vger.kernel.org>, <jh80.chung@samsung.com>
Subject: Re: [PATCH v2] brcmfmac: Fix memory leak for unpaired brcmf_{alloc/free}
Date: Mon, 02 Nov 2020 19:46:00 +0200 [thread overview]
Message-ID: <87h7q7odnr.fsf@codeaurora.org> (raw)
In-Reply-To: <1758a0b5580.279b.9b12b7fc0a3841636cfb5e919b41b954@broadcom.com> (Arend Van Spriel's message of "Mon, 02 Nov 2020 18:40:00 +0100")
Arend Van Spriel <arend.vanspriel@broadcom.com> writes:
> On November 2, 2020 6:15:32 PM Kalle Valo <kvalo@codeaurora.org> wrote:
>
>> Seung-Woo Kim <sw0312.kim@samsung.com> writes:
>>
>>> There are missig brcmf_free() for brcmf_alloc(). Fix memory leak
>>> by adding missed brcmf_free().
>>>
>>> Reported-by: Jaehoon Chung <jh80.chung@samsung.com>
>>> Fixes: commit 450914c39f88 ("brcmfmac: split brcmf_attach() and
>>> brcmf_detach() functions")
>>
>> This should be:
>>
>> Fixes: 450914c39f88 ("brcmfmac: split brcmf_attach() and
>> brcmf_detach() functions")
>>
>> But I can fix that, no need to resend because of this.
>
> Hi Kalle,
>
> But this is not the commit that needs fixing as I mentioned before.
> Instead it should be a1f5aac1765af ("brcmfmac: don't realloc wiphy
> during PCIe reset") which introduced the actual memory leak.
I'll then change it to:
Fixes: a1f5aac1765a ("brcmfmac: don't realloc wiphy during PCIe reset")
Is that ok?
--
https://patchwork.kernel.org/project/linux-wireless/list/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
next prev parent reply other threads:[~2020-11-02 17:46 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20201028015033epcas1p4f3d9b38b037ff6d4432e1a2866544e38@epcas1p4.samsung.com>
2020-10-28 1:52 ` [PATCH v2] brcmfmac: Fix memory leak for unpaired brcmf_{alloc/free} Seung-Woo Kim
2020-11-02 17:15 ` Kalle Valo
2020-11-02 17:40 ` Arend Van Spriel
2020-11-02 17:46 ` Kalle Valo [this message]
2020-11-02 18:13 ` Arend Van Spriel
2020-11-07 16:19 ` [v2] " Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87h7q7odnr.fsf@codeaurora.org \
--to=kvalo@codeaurora.org \
--cc=amsr@cypress.com \
--cc=arend.vanspriel@broadcom.com \
--cc=brcm80211-dev-list.pdl@broadcom.com \
--cc=brcm80211-dev-list@cypress.com \
--cc=chi-hsien.lin@cypress.com \
--cc=davem@davemloft.net \
--cc=digetx@gmail.com \
--cc=double.lo@cypress.com \
--cc=frank.kao@cypress.com \
--cc=franky.lin@broadcom.com \
--cc=hante.meuleman@broadcom.com \
--cc=jean-philippe@linaro.org \
--cc=jh80.chung@samsung.com \
--cc=kuba@kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=rafal@milecki.pl \
--cc=sandals@crustytoothpaste.net \
--cc=saravanan.shanmugham@cypress.com \
--cc=smoch@web.de \
--cc=stanley.hsu@cypress.com \
--cc=sw0312.kim@samsung.com \
--cc=wright.feng@cypress.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).