From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 231C9C00A89 for ; Mon, 2 Nov 2020 17:46:13 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C02E222277 for ; Mon, 2 Nov 2020 17:46:12 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=mg.codeaurora.org header.i=@mg.codeaurora.org header.b="s+Xm4DgC" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725806AbgKBRqL (ORCPT ); Mon, 2 Nov 2020 12:46:11 -0500 Received: from z5.mailgun.us ([104.130.96.5]:11827 "EHLO z5.mailgun.us" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725768AbgKBRqK (ORCPT ); Mon, 2 Nov 2020 12:46:10 -0500 DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=mg.codeaurora.org; q=dns/txt; s=smtp; t=1604339169; h=Content-Type: MIME-Version: Message-ID: In-Reply-To: Date: References: Subject: Cc: To: From: Sender; bh=mKqqjTvaORCG3AeoHLDKVzVZE7c/OvrfkPwelnmYgoo=; b=s+Xm4DgCti2sWvhFgSWfcKbrXkv+KY95nxGBOZMgRWSjt1qme4yj7piKVyZbzly07AqS47QS P42nJcy0t2ZN24yNJIr+vcJmeXWQtAPrGloqv6FTWvpx8bkyZfmycWAXigZ+3+xphAWXObXS cf2WnzLEiaQ0yT6s1QpBg8ft5aM= X-Mailgun-Sending-Ip: 104.130.96.5 X-Mailgun-Sid: WyJiZjI2MiIsICJuZXRkZXZAdmdlci5rZXJuZWwub3JnIiwgImJlOWU0YSJd Received: from smtp.codeaurora.org (ec2-35-166-182-171.us-west-2.compute.amazonaws.com [35.166.182.171]) by smtp-out-n06.prod.us-east-1.postgun.com with SMTP id 5fa045e041e7c4fae793125b (version=TLS1.2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256); Mon, 02 Nov 2020 17:46:08 GMT Sender: kvalo=codeaurora.org@mg.codeaurora.org Received: by smtp.codeaurora.org (Postfix, from userid 1001) id 2D11CC433FF; Mon, 2 Nov 2020 17:46:08 +0000 (UTC) Received: from x230.qca.qualcomm.com (88-114-240-156.elisa-laajakaista.fi [88.114.240.156]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: kvalo) by smtp.codeaurora.org (Postfix) with ESMTPSA id 52915C433C9; Mon, 2 Nov 2020 17:46:02 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 52915C433C9 Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; spf=fail smtp.mailfrom=kvalo@codeaurora.org From: Kalle Valo To: Arend Van Spriel Cc: "Seung-Woo Kim" , , , , , , , , , , , , , , , , , , , , , Subject: Re: [PATCH v2] brcmfmac: Fix memory leak for unpaired brcmf_{alloc/free} References: <1603849967-22817-1-git-send-email-sw0312.kim@samsung.com> <87pn4vof2s.fsf@codeaurora.org> <1758a0b5580.279b.9b12b7fc0a3841636cfb5e919b41b954@broadcom.com> Date: Mon, 02 Nov 2020 19:46:00 +0200 In-Reply-To: <1758a0b5580.279b.9b12b7fc0a3841636cfb5e919b41b954@broadcom.com> (Arend Van Spriel's message of "Mon, 02 Nov 2020 18:40:00 +0100") Message-ID: <87h7q7odnr.fsf@codeaurora.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Arend Van Spriel writes: > On November 2, 2020 6:15:32 PM Kalle Valo wrote: > >> Seung-Woo Kim writes: >> >>> There are missig brcmf_free() for brcmf_alloc(). Fix memory leak >>> by adding missed brcmf_free(). >>> >>> Reported-by: Jaehoon Chung >>> Fixes: commit 450914c39f88 ("brcmfmac: split brcmf_attach() and >>> brcmf_detach() functions") >> >> This should be: >> >> Fixes: 450914c39f88 ("brcmfmac: split brcmf_attach() and >> brcmf_detach() functions") >> >> But I can fix that, no need to resend because of this. > > Hi Kalle, > > But this is not the commit that needs fixing as I mentioned before. > Instead it should be a1f5aac1765af ("brcmfmac: don't realloc wiphy > during PCIe reset") which introduced the actual memory leak. I'll then change it to: Fixes: a1f5aac1765a ("brcmfmac: don't realloc wiphy during PCIe reset") Is that ok? -- https://patchwork.kernel.org/project/linux-wireless/list/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches