netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Toke Høiland-Jørgensen" <toke@redhat.com>
To: Luigi Rizzo <lrizzo@google.com>,
	netdev@vger.kernel.org, davem@davemloft.net, hawk@kernel.org,
	sameehj@amazon.com
Cc: linux-kernel@vger.kernel.org, Luigi Rizzo <lrizzo@google.com>
Subject: Re: [PATCH v3 net-next] netdev attribute to control xdpgeneric skb linearization
Date: Fri, 28 Feb 2020 11:16:36 +0100	[thread overview]
Message-ID: <87h7zbuid7.fsf@toke.dk> (raw)
In-Reply-To: <20200227173428.5298-1-lrizzo@google.com>

Luigi Rizzo <lrizzo@google.com> writes:

> Add a netdevice flag to control skb linearization in generic xdp mode.
>
> The attribute can be modified through
> 	/sys/class/net/<DEVICE>/xdp_linearize
> The default is 1 (on)

Calling it just 'xdp_linearize' implies (to me) that it also affects
driver-mode XDP. So maybe generic_xdp_linearize ?

[...]

> +
> +What:		/sys/class/net/<iface>/xdp_linearize
> +Date:		Jan 2020
> +KernelVersion:	5.6
> +Contact:	netdev@vger.kernel.org
> +Description:
> +		boolean controlling whether skb should be linearized in
> +		generic xdp. Defaults to true.

Could you also add a few words explaining what the tradeoff here is?
Something like: "turning this off can increase the performance of
generic XDP at the cost of making the content of making the XDP program
unable to access packet fragments after the first one"

-Toke


  reply	other threads:[~2020-02-28 10:16 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-02-27 17:34 [PATCH v3 net-next] netdev attribute to control xdpgeneric skb linearization Luigi Rizzo
2020-02-28 10:16 ` Toke Høiland-Jørgensen [this message]
2020-02-28 10:56   ` Luigi Rizzo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87h7zbuid7.fsf@toke.dk \
    --to=toke@redhat.com \
    --cc=davem@davemloft.net \
    --cc=hawk@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lrizzo@google.com \
    --cc=netdev@vger.kernel.org \
    --cc=sameehj@amazon.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).