From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2119ECA9EAF for ; Thu, 24 Oct 2019 13:26:02 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 024022084C for ; Thu, 24 Oct 2019 13:26:02 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388895AbfJXN0B (ORCPT ); Thu, 24 Oct 2019 09:26:01 -0400 Received: from mx1.redhat.com ([209.132.183.28]:53746 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2387516AbfJXN0A (ORCPT ); Thu, 24 Oct 2019 09:26:00 -0400 Received: from mail-lj1-f197.google.com (mail-lj1-f197.google.com [209.85.208.197]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 7721259451 for ; Thu, 24 Oct 2019 13:26:00 +0000 (UTC) Received: by mail-lj1-f197.google.com with SMTP id v19so4001372ljc.15 for ; Thu, 24 Oct 2019 06:26:00 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:in-reply-to:references:date :message-id:mime-version; bh=+ZpJtPYK8YP0WE7ZBrQ7oSDcwMJnV8kp7n/BALIslZE=; b=mdsj0SmZmLqFaG+pKEvh5Cl2v9vKiWpELgRCl0PoRH5gQHzBVlc+3tygwFatBHiHoC e4QT1p2qb3TkRDYkHOaL/wPK9t4dIC3O8t2EuUSFtP2dRvjdXQTGfNGMstDUxhY8y2j6 iEllP4XgbnFLIXsbeleeUrG8y/meLu2b1gIFkLKkjKH7eHy7o2ucN9oQHuGm3/AFGCRe igKR6cL/5WsraEOtT1orjZPNe8lt+DS5i+t3btvvv9H9mR32iVQRjy6TT2mYFp8ZVYI/ N/8Wqs5n8/KXtd+l/jjNr3GFEqv0lPpce0abUOtzwk7MATuunk3rH+xS9MjDw1IyXuNB PD7A== X-Gm-Message-State: APjAAAVWOrFHL+0fsUj5YONvItibfcaE3Ct09vAG5qtG/r9nGwe9VQAo AX/d41Kq7i00xLULnz44LyVee9WI4bxVgmGjb0mmnjqPH7pWuVDopmWjJRpJtbYZpi/ViHwUXni DSnTKsZlphFpt52bf X-Received: by 2002:a2e:7212:: with SMTP id n18mr2281742ljc.246.1571923558846; Thu, 24 Oct 2019 06:25:58 -0700 (PDT) X-Google-Smtp-Source: APXvYqxtE53w17ZF5FP6OkovcF6gQ3sVTn0QZi+tjbcw9ZRpu5zHatsousFIR6buOuIn4nGuzDDwTA== X-Received: by 2002:a2e:7212:: with SMTP id n18mr2281727ljc.246.1571923558666; Thu, 24 Oct 2019 06:25:58 -0700 (PDT) Received: from alrua-x1.borgediget.toke.dk ([2a00:7660:6da:443::2]) by smtp.gmail.com with ESMTPSA id f22sm10509317lfk.56.2019.10.24.06.25.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 24 Oct 2019 06:25:58 -0700 (PDT) Received: by alrua-x1.borgediget.toke.dk (Postfix, from userid 1000) id 244971804B1; Thu, 24 Oct 2019 15:25:57 +0200 (CEST) From: Toke =?utf-8?Q?H=C3=B8iland-J=C3=B8rgensen?= To: Daniel Borkmann Cc: Alexei Starovoitov , Martin KaFai Lau , Song Liu , Yonghong Song , Jesper Dangaard Brouer , Andrii Nakryiko , David Miller , netdev@vger.kernel.org, bpf@vger.kernel.org Subject: Re: [PATCH bpf-next v2 3/4] libbpf: Support configurable pinning of maps from BTF annotations In-Reply-To: <157192270077.234778.5965993521171571751.stgit@toke.dk> References: <157192269744.234778.11792009511322809519.stgit@toke.dk> <157192270077.234778.5965993521171571751.stgit@toke.dk> X-Clacks-Overhead: GNU Terry Pratchett Date: Thu, 24 Oct 2019 15:25:57 +0200 Message-ID: <87h83yl1ga.fsf@toke.dk> MIME-Version: 1.0 Content-Type: text/plain Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org > +int bpf_object__pin_maps(struct bpf_object *obj, const char *path) > +{ > + LIBBPF_OPTS(bpf_object_pin_opts, opts, > + .pin_path = path, > + .pin_all = (path != NULL)); > + return bpf_object__pin_maps_opts(obj, &opts); > +} Hmm, seems I forgot to pull before sending; this should be LIBBPF_DECLARE_OPTS now. Will fix in the next version, but I'll give y'all a chance to comment on this version first :) -Toke