From: Petr Machata <petrm@mellanox.com>
To: Roopa Prabhu <roopa@cumulusnetworks.com>
Cc: "davem@davemloft.net" <davem@davemloft.net>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"dsa@cumulusnetworks.com" <dsa@cumulusnetworks.com>,
"sd@queasysnail.net" <sd@queasysnail.net>,
"johannes@sipsolutions.net" <johannes@sipsolutions.net>
Subject: Re: [PATCH net-next 1/2] vxlan: add extack support for create and changelink
Date: Tue, 26 Feb 2019 17:45:05 +0000 [thread overview]
Message-ID: <87h8cqfnq8.fsf@mellanox.com> (raw)
In-Reply-To: <CAJieiUhKFrhoMcy-Bz1JmWEQ=8OooeZpb_sbD6zcKwotfJooBQ@mail.gmail.com>
Roopa Prabhu <roopa@cumulusnetworks.com> writes:
> On Tue, Feb 26, 2019 at 5:51 AM Petr Machata <petrm@mellanox.com> wrote:
>>
>> Many of the flags for which you call this don't actually have the else
>> branch. However I suspect there are no good reasons not to allow
>> resetting a flag.
>>
>> Reviewed-by: Petr Machata <petrm@mellanox.com>
>
> yes, correct, that was intentional.
> also, I am not sure what is the best way to support reseting of a NLA_FLAG.
> Absence of the flag attribute in the request cannot be the reason for
> resetting or clearing the flag.
Yeah, I was thinking about that. It looks like this would need a new set
of u8 attributes :-(
> None of the NLA_FLAG attributes support changing the flag today. This
> patch does not change that.
next prev parent reply other threads:[~2019-02-26 17:45 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-26 6:03 [PATCH net-next 0/2] vxlan: create and changelink extack support Roopa Prabhu
2019-02-26 6:03 ` [PATCH net-next 1/2] vxlan: add extack support for create and changelink Roopa Prabhu
2019-02-26 13:51 ` Petr Machata
2019-02-26 14:06 ` Roopa Prabhu
2019-02-26 17:45 ` Petr Machata [this message]
2019-02-27 1:05 ` Roopa Prabhu
2019-02-26 6:03 ` [PATCH net-next 2/2] tools: selftests: rtnetlink: add testcases for vxlan flag sets Roopa Prabhu
2019-02-26 17:01 ` [PATCH net-next 0/2] vxlan: create and changelink extack support David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87h8cqfnq8.fsf@mellanox.com \
--to=petrm@mellanox.com \
--cc=davem@davemloft.net \
--cc=dsa@cumulusnetworks.com \
--cc=johannes@sipsolutions.net \
--cc=netdev@vger.kernel.org \
--cc=roopa@cumulusnetworks.com \
--cc=sd@queasysnail.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).