From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DFF99C43381 for ; Tue, 26 Feb 2019 17:45:17 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id A59DE2184D for ; Tue, 26 Feb 2019 17:45:17 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=Mellanox.com header.i=@Mellanox.com header.b="o7gLr9n2" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728736AbfBZRpQ (ORCPT ); Tue, 26 Feb 2019 12:45:16 -0500 Received: from mail-eopbgr60061.outbound.protection.outlook.com ([40.107.6.61]:62688 "EHLO EUR04-DB3-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1727416AbfBZRpK (ORCPT ); Tue, 26 Feb 2019 12:45:10 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=DELj/2VupN8PclX+B547zJbLVrazsrHa6gQ84ck2VIk=; b=o7gLr9n26jas6YICBzZZ/7JjpJC9V3AsZJcC2lqB2ewwzACNIuJubeYR3J6ABwp9edG4cLpHe+9jTuLpYtp4+TfYBeefFaAuzE+LA0oMZmhDSwBgUsrCJuLaCtb0XHH9SXZMOKb4r7WHJSZ5+DT6sAduTuk/PUVOUOwHS+uVatA= Received: from VI1PR05MB3247.eurprd05.prod.outlook.com (10.170.238.16) by VI1PR05MB5965.eurprd05.prod.outlook.com (20.178.126.221) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1643.14; Tue, 26 Feb 2019 17:45:05 +0000 Received: from VI1PR05MB3247.eurprd05.prod.outlook.com ([fe80::210b:6763:af21:4f43]) by VI1PR05MB3247.eurprd05.prod.outlook.com ([fe80::210b:6763:af21:4f43%6]) with mapi id 15.20.1643.019; Tue, 26 Feb 2019 17:45:05 +0000 From: Petr Machata To: Roopa Prabhu CC: "davem@davemloft.net" , "netdev@vger.kernel.org" , "dsa@cumulusnetworks.com" , "sd@queasysnail.net" , "johannes@sipsolutions.net" Subject: Re: [PATCH net-next 1/2] vxlan: add extack support for create and changelink Thread-Topic: [PATCH net-next 1/2] vxlan: add extack support for create and changelink Thread-Index: AQHUzZj5T61NX3KyQEKyA9DSfurH4KXyGXYAgAAEPQCAAD0cgA== Date: Tue, 26 Feb 2019 17:45:05 +0000 Message-ID: <87h8cqfnq8.fsf@mellanox.com> References: <1551160982-32685-1-git-send-email-roopa@cumulusnetworks.com> <1551160982-32685-2-git-send-email-roopa@cumulusnetworks.com> <87imx6fyk1.fsf@mellanox.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-clientproxiedby: AM6P194CA0045.EURP194.PROD.OUTLOOK.COM (2603:10a6:209:84::22) To VI1PR05MB3247.eurprd05.prod.outlook.com (2603:10a6:802:1c::16) authentication-results: spf=none (sender IP is ) smtp.mailfrom=petrm@mellanox.com; x-ms-exchange-messagesentrepresentingtype: 1 x-originating-ip: [78.45.160.211] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 71941649-20b3-4d33-fe87-08d69c12243f x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0;PCL:0;RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600127)(711020)(4605104)(4618075)(2017052603328)(7153060)(7193020);SRVR:VI1PR05MB5965; x-ms-traffictypediagnostic: VI1PR05MB5965: x-microsoft-exchange-diagnostics: =?iso-8859-1?Q?1;VI1PR05MB5965;23:UEMlTIa3AqlURwszL83dTLo2++7e+Zdyyz1hzht?= =?iso-8859-1?Q?wmMQIuf2VZH9PYiJgAL/p/jHpnyDyF2sFSXZjfCVpxvfSzK6fF20dwF/5K?= =?iso-8859-1?Q?5CVpr+XNHh/GuG35/3r22gay8p8kuBV/CqQOU+vVdMRGPVN/IHFeTB4VuO?= =?iso-8859-1?Q?CBfP2OYI6PBpciqBj9jRz5FaMkRHpA9vTJM8RxGAcBZeQBZYmUqljOIb4U?= =?iso-8859-1?Q?BBNgNwOn66UZeDcBGBTlX3UZQgXETMics7B3gJ0dDC2kuYxKYfytChDB4k?= =?iso-8859-1?Q?VxhV/E6IRekv5kLvHKeZzppZQZkvfaW9Jo0SruI6qDcHLxySU4PKvjWsrz?= =?iso-8859-1?Q?bctXS+3fxCmr0JQkLu8cXsbbE4fZYkI0Jj7Xe7fH9Li0f0mdxMUWO9v3t2?= =?iso-8859-1?Q?7d7Ij296kqRDcY/LQm0rAVM9vR6gJsWxX9s+zfBsn3p8fSn6AdWkiCz57b?= =?iso-8859-1?Q?AlIPdGG0IgR514cZk8rR5oZaurogaOJ/f6ig2XfXLXu4oxmiw8sCpAn1In?= =?iso-8859-1?Q?xPcE5n4AJ6MSrsPVJ8YO8Z3v6zGAtUgw9o2woOEWKLX60ZZ74CcdjwP91t?= =?iso-8859-1?Q?mFJDQm2GWkMEycINj/dpDflHefYSOQ1c1PavBAQBmQwd2qOgJhPHRHkcgk?= =?iso-8859-1?Q?2vfxM+J2psVuK7ZLrgJ+P1V218FHbsPLK6LY+Kl9cRQvmkgoeSsI2vUzyM?= =?iso-8859-1?Q?S9hWZ2hGQ/Hq+H73uzJFRbSu82E3TQiJxvXRLRfjV5CSmgJm6ZUmZgannL?= =?iso-8859-1?Q?eBbhFbrdBfYI78ZSs35RhlSUfP1IzS/2dWAEMpBmF/wrgaAoV2BUAtpNUy?= =?iso-8859-1?Q?pkcPMHkn92ZxNv6GgA1eSc6CDJbKqQs1RJ1liK+K2r6s6y1QBQNei/CIQ1?= =?iso-8859-1?Q?cZ//3mHYs5IQoL/yoliiZgpTlk6SguUQul01srgmmGMtgGIPnbV7E6y0Mi?= =?iso-8859-1?Q?N/Mf1U5ahcDqBROhlzZZVEopbVeA4BLp92pCiSA60AtARA78MQF61WxjPn?= =?iso-8859-1?Q?woEtQm0eYZer3SWVltj0RCuZH31EKF0hJ5bHcThoNtAgaUQ9OLp+umy9T9?= =?iso-8859-1?Q?cMwML1UR9Mgp2SXF2UcwR87FrX1wNvNWiEizrQmBpVqjhJAhLGSPkpCDiX?= =?iso-8859-1?Q?AyyGPmqUAs9lKyhgeUx1blG2k9plYUGHQPMVS4Tn5tQmrese+UJab5v1/Y?= =?iso-8859-1?Q?PSVcxfhknnSGPwkFI4dGvmFV20DL4J0VjKbKL8oXBEN/NNSZzki73nxzHo?= =?iso-8859-1?Q?IZq1y6ocFM4GFzP4313aIFfvh2Om/HIpZ0Lv8gqcEyFaI6UQ3PrRcQ5Quz?= =?iso-8859-1?Q?1X4C1Kl65WxgGBXRg4cGUGtaT/jezpcWo1HhzIbalCEQQ=3D=3D?= x-microsoft-antispam-prvs: x-forefront-prvs: 096029FF66 x-forefront-antispam-report: SFV:NSPM;SFS:(10009020)(376002)(366004)(346002)(396003)(136003)(39860400002)(189003)(199004)(14454004)(54906003)(316002)(97736004)(106356001)(14444005)(478600001)(105586002)(99286004)(52116002)(76176011)(66066001)(86362001)(4744005)(6916009)(53546011)(6506007)(386003)(446003)(81156014)(102836004)(305945005)(81166006)(8676002)(25786009)(186003)(11346002)(486006)(7736002)(53936002)(476003)(6246003)(4326008)(2616005)(8936002)(6436002)(6512007)(2906002)(36756003)(3846002)(256004)(5660300002)(6116002)(26005)(68736007)(6486002)(229853002)(71200400001)(71190400001)(93886005);DIR:OUT;SFP:1101;SCL:1;SRVR:VI1PR05MB5965;H:VI1PR05MB3247.eurprd05.prod.outlook.com;FPR:;SPF:None;LANG:en;PTR:InfoNoRecords;MX:1;A:1; received-spf: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: R5pYzM2NEzdu3BYxuQV9rfW/RGn0xdq/98CR6sjAMqhFo7pCC1P1RDhERGIdJ/hoic01JhMx4x56RkO9i00rKW1Fg2n1+poSS/8bbfRg4vqW7WA01kR7gPS4yuE2MwclY47gvoaC5EaAeN3wYwT4zabMnsMvEYuFq6+o13IXA1shcW+Bvr5NK6Ny+ivSoibYCFepUAZaUO2fFAMJRa+XnFgbbJAXXGcPXQP74teG/LCQt5magDYBSdRK6hrv7nax0w22uhVPlACf+gdtH4X3HtcGVydu89ccXTdJFUgPFnY464dSrzRZKCocyCxQYb64V9cww16yZsyXVr8TEV7oATgcFf7mvVg7e/PELRg7X916hi1FTtyLQI5VUK5t/DCDSK+75Y2ZH6QygzbqXb2yUs4GHXDnweB+y0Oi/Ej+ClE= Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: 71941649-20b3-4d33-fe87-08d69c12243f X-MS-Exchange-CrossTenant-originalarrivaltime: 26 Feb 2019 17:45:04.6899 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR05MB5965 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Roopa Prabhu writes: > On Tue, Feb 26, 2019 at 5:51 AM Petr Machata wrote: >> >> Many of the flags for which you call this don't actually have the else >> branch. However I suspect there are no good reasons not to allow >> resetting a flag. >> >> Reviewed-by: Petr Machata > > yes, correct, that was intentional. > also, I am not sure what is the best way to support reseting of a NLA_FLA= G. > Absence of the flag attribute in the request cannot be the reason for > resetting or clearing the flag. Yeah, I was thinking about that. It looks like this would need a new set of u8 attributes :-( > None of the NLA_FLAG attributes support changing the flag today. This > patch does not change that.